Skip to content

Conversation

@mayanksharma27
Copy link
Contributor

@mayanksharma27 mayanksharma27 commented Mar 17, 2025

Description

Add changes to support pinning in FileCache

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • [Y ] Functionality includes testing.
  • [NA] API changes companion pull request created, if applicable.
  • [NA] Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

❌ Gradle check result for 353bcdf: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Mayank Sharma <smynk@amazon.com>
@github-actions
Copy link
Contributor

❌ Gradle check result for 97de675: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Gaurav Bafna <85113518+gbbafna@users.noreply.github.com>
@github-actions
Copy link
Contributor

❌ Gradle check result for 80062af: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@gbbafna gbbafna changed the title Added Changes to support Cache pinning in FileCache Add changes to support pinning in FileCache May 27, 2025
@github-actions
Copy link
Contributor

✅ Gradle check result for 80062af: SUCCESS

@codecov
Copy link

codecov bot commented May 27, 2025

Codecov Report

Attention: Patch coverage is 73.23944% with 38 lines in your changes missing coverage. Please review.

Project coverage is 72.65%. Comparing base (aec3fe9) to head (80062af).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
...search/index/store/remote/filecache/FileCache.java 33.33% 12 Missing ⚠️
...earch/index/store/remote/utils/cache/LRUCache.java 78.04% 4 Missing and 5 partials ⚠️
...index/store/remote/utils/cache/SegmentedCache.java 58.82% 5 Missing and 2 partials ⚠️
...ils/cache/stats/AggregateRefCountedCacheStats.java 42.85% 4 Missing ⚠️
...ore/remote/utils/cache/stats/FileStatsCounter.java 87.87% 2 Missing and 2 partials ⚠️
.../remote/utils/cache/stats/DefaultStatsCounter.java 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #17617      +/-   ##
============================================
+ Coverage     72.52%   72.65%   +0.13%     
- Complexity    67496    67552      +56     
============================================
  Files          5495     5495              
  Lines        311433   311537     +104     
  Branches      45249    45263      +14     
============================================
+ Hits         225867   226355     +488     
+ Misses        67179    66703     -476     
- Partials      18387    18479      +92     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-project-automation github-project-automation bot moved this to 👀 In review in Storage Project Board May 27, 2025
Copy link
Contributor

@rayshrey rayshrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gbbafna gbbafna merged commit 9bca961 into opensearch-project:main May 28, 2025
33 checks passed
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Storage Project Board May 28, 2025
Gagan6164 pushed a commit to Gagan6164/OpenSearch that referenced this pull request Jun 8, 2025
Signed-off-by: Mayank Sharma <smynk@amazon.com>
Signed-off-by: Gaurav Bafna <85113518+gbbafna@users.noreply.github.com>
Co-authored-by: Gaurav Bafna <85113518+gbbafna@users.noreply.github.com>
Gagan6164 pushed a commit to Gagan6164/OpenSearch that referenced this pull request Jun 8, 2025
Signed-off-by: Mayank Sharma <smynk@amazon.com>
Signed-off-by: Gaurav Bafna <85113518+gbbafna@users.noreply.github.com>
Co-authored-by: Gaurav Bafna <85113518+gbbafna@users.noreply.github.com>
neuenfeldttj added a commit to neuenfeldttj/OpenSearch that referenced this pull request Jun 26, 2025
Signed-off-by: Mayank Sharma <smynk@amazon.com>
Signed-off-by: Gaurav Bafna <85113518+gbbafna@users.noreply.github.com>
Co-authored-by: Gaurav Bafna <85113518+gbbafna@users.noreply.github.com>Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com>
neuenfeldttj pushed a commit to neuenfeldttj/OpenSearch that referenced this pull request Jun 26, 2025
Signed-off-by: Mayank Sharma <smynk@amazon.com>
Signed-off-by: Gaurav Bafna <85113518+gbbafna@users.noreply.github.com>
Co-authored-by: Gaurav Bafna <85113518+gbbafna@users.noreply.github.com>
tandonks pushed a commit to tandonks/OpenSearch that referenced this pull request Aug 5, 2025
Signed-off-by: Mayank Sharma <smynk@amazon.com>
Signed-off-by: Gaurav Bafna <85113518+gbbafna@users.noreply.github.com>
Co-authored-by: Gaurav Bafna <85113518+gbbafna@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Enhancement or improvement to existing feature or request Storage:Remote

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

[Writable Warm] File Pinning support in FileCache

4 participants