-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Add changes to support pinning in FileCache #17617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add changes to support pinning in FileCache #17617
Conversation
|
❌ Gradle check result for 353bcdf: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
server/src/main/java/org/opensearch/index/store/remote/utils/cache/LRUCache.java
Show resolved
Hide resolved
server/src/main/java/org/opensearch/index/store/CompositeDirectory.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/index/store/remote/utils/cache/LRUCache.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/index/store/remote/utils/cache/LRUCache.java
Show resolved
Hide resolved
Signed-off-by: Mayank Sharma <smynk@amazon.com>
e04cade to
97de675
Compare
|
❌ Gradle check result for 97de675: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Gaurav Bafna <85113518+gbbafna@users.noreply.github.com>
|
❌ Gradle check result for 80062af: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17617 +/- ##
============================================
+ Coverage 72.52% 72.65% +0.13%
- Complexity 67496 67552 +56
============================================
Files 5495 5495
Lines 311433 311537 +104
Branches 45249 45263 +14
============================================
+ Hits 225867 226355 +488
+ Misses 67179 66703 -476
- Partials 18387 18479 +92 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rayshrey
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Mayank Sharma <smynk@amazon.com> Signed-off-by: Gaurav Bafna <85113518+gbbafna@users.noreply.github.com> Co-authored-by: Gaurav Bafna <85113518+gbbafna@users.noreply.github.com>
Signed-off-by: Mayank Sharma <smynk@amazon.com> Signed-off-by: Gaurav Bafna <85113518+gbbafna@users.noreply.github.com> Co-authored-by: Gaurav Bafna <85113518+gbbafna@users.noreply.github.com>
Signed-off-by: Mayank Sharma <smynk@amazon.com> Signed-off-by: Gaurav Bafna <85113518+gbbafna@users.noreply.github.com> Co-authored-by: Gaurav Bafna <85113518+gbbafna@users.noreply.github.com>Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com>
Signed-off-by: Mayank Sharma <smynk@amazon.com> Signed-off-by: Gaurav Bafna <85113518+gbbafna@users.noreply.github.com> Co-authored-by: Gaurav Bafna <85113518+gbbafna@users.noreply.github.com>
Signed-off-by: Mayank Sharma <smynk@amazon.com> Signed-off-by: Gaurav Bafna <85113518+gbbafna@users.noreply.github.com> Co-authored-by: Gaurav Bafna <85113518+gbbafna@users.noreply.github.com>
Description
Add changes to support pinning in FileCache
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.