Skip to content

Conversation

@RajatGupta02
Copy link
Contributor

Description

Fix systemd configs

Related Issues

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Rajat Gupta <gptrajat@amazon.com>
@kumargu
Copy link
Contributor

kumargu commented Apr 29, 2025

to fasten RC1 build, we can skip waiting for gradle checks since the config is used only in bundling and doesn't effect core.

@peterzhuamazon peterzhuamazon merged commit e891017 into opensearch-project:3.0 Apr 29, 2025
64 of 67 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to main failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-main main
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-main
# Create a new branch
git switch --create backport/backport-18134-to-main
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e891017f6afc0bc4ba13181e5e14d24d47e69938
# Push it to GitHub
git push --set-upstream origin backport/backport-18134-to-main
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-main

Then, create a pull request where the base branch is main and the compare/head branch is backport/backport-18134-to-main.

@kumargu
Copy link
Contributor

kumargu commented Apr 29, 2025

@RajatGupta02 let's also work in parallel to make sure that creation of the /dev/shm/performanceanalyzer in systemd won't conflict creation from within PA plugin.

@github-actions
Copy link
Contributor

❌ Gradle check result for 52c79a6: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

✅ Gradle check result for 52c79a6: SUCCESS

@codecov
Copy link

codecov bot commented Apr 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.47%. Comparing base (e0272e0) to head (52c79a6).
Report is 12 commits behind head on 3.0.

Additional details and impacted files
@@             Coverage Diff              @@
##                3.0   #18134      +/-   ##
============================================
- Coverage     72.58%   72.47%   -0.11%     
- Complexity    67139    67154      +15     
============================================
  Files          5478     5480       +2     
  Lines        310120   310318     +198     
  Branches      45080    45140      +60     
============================================
- Hits         225092   224909     -183     
- Misses        66684    67013     +329     
- Partials      18344    18396      +52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RajatGupta02 RajatGupta02 deleted the systemd-config branch April 30, 2025 07:57
prudhvigodithi pushed a commit to prudhvigodithi/OpenSearch that referenced this pull request May 6, 2025
Signed-off-by: Rajat Gupta <gptrajat@amazon.com>
Co-authored-by: Rajat Gupta <gptrajat@amazon.com>
Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants