Skip to content

Fix flaky RepositoriesServiceIT.testCreatSnapAndUpdateReposityCauseInfiniteLoop #18199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrross merged 1 commit into from
May 5, 2025
Merged

Fix flaky RepositoriesServiceIT.testCreatSnapAndUpdateReposityCauseInfiniteLoop #18199

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 14 additions & 11 deletions server/src/internalClusterTest/java/org/opensearch/repositories/RepositoriesServiceIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,6 @@ public void testSystemRepositoryCantBeCreated() {
assertThrows(RepositoryException.class, () -> createRepository(repositoryName, FsRepository.TYPE, repoSettings));
}

@AwaitsFix(bugUrl = "https://github.com/opensearch-project/OpenSearch/issues/15842")
public void testCreatSnapAndUpdateReposityCauseInfiniteLoop() throws InterruptedException {
// create index
internalCluster();
Expand Down Expand Up @@ -173,16 +172,20 @@ public void testCreatSnapAndUpdateReposityCauseInfiniteLoop() throws Interrupted
});
thread.start();

logger.info("--> begin to reset repository");
repoSettings = Settings.builder().put("location", randomRepoPath()).put("max_snapshot_bytes_per_sec", "300mb");
OpenSearchIntegTestCase.putRepositoryWithNoSettingOverrides(
client().admin().cluster(),
repositoryName,
FsRepository.TYPE,
true,
repoSettings
);
logger.info("--> finish to reset repository");
try {
logger.info("--> begin to reset repository");
repoSettings = Settings.builder().put("location", randomRepoPath()).put("max_snapshot_bytes_per_sec", "300mb");
OpenSearchIntegTestCase.putRepositoryWithNoSettingOverrides(
client().admin().cluster(),
repositoryName,
FsRepository.TYPE,
true,
repoSettings
);
logger.info("--> finish to reset repository");
} catch (IllegalStateException e) {
assertThat(e, hasToString(containsString(("trying to modify or unregister repository that is currently used"))));
}

// after updating repository, snapshot should be success
createSnapshot.run();
Expand Down
Loading