-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Update concurrency setting for gradle check to exclude cancellation of the post_merge runs #18283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Adding @andrross @gaiksaya @getsaurabh02 |
Member
|
Does this mean PRs will now get a comment about the cancelled Jenkins job when a new PR revision is pushed? |
Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
5a16580 to
6c15d91
Compare
Member
Author
andrross
approved these changes
May 14, 2025
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 14, 2025
Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> (cherry picked from commit dd61c5d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 14, 2025
Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> (cherry picked from commit dd61c5d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 14, 2025
Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> (cherry picked from commit dd61c5d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
tanik98
pushed a commit
to tanik98/OpenSearch
that referenced
this pull request
May 27, 2025
…-project#18283) Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
tandonks
pushed a commit
to tandonks/OpenSearch
that referenced
this pull request
Jun 1, 2025
…-project#18283) Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
neuenfeldttj
pushed a commit
to neuenfeldttj/OpenSearch
that referenced
this pull request
Jun 26, 2025
…-project#18283) Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com>
neuenfeldttj
pushed a commit
to neuenfeldttj/OpenSearch
that referenced
this pull request
Jun 26, 2025
…-project#18283) Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


Description
Today for a post merge action the running gradle check CI runs are terminated with the concurrency setting.
Here is an example https://github.com/opensearch-project/OpenSearch/actions/runs/14934871450/job/41959850100 where the operation was cancelled by the Github. This can happen when a new PR is merged while for the previous PR post merge run is still running. I assume this is because
${{ github.event.pull_request.number }}shows null for a post merge actions.But notice this dint actually stop the triggered Jenkins job https://build.ci.opensearch.org/job/gradle-check/57901/. This concurrency setting only terminates at the Github level.
Today for Jenkins this is already handled (https://github.com/opensearch-project/opensearch-build/blob/main/jenkins/gradle/gradle-check.jenkinsfile#L125) to abort the Jenkins jobs for the same PR. So for an open PR upon a new commit when triggered a Jenkins job it will abort the existing running build.
Having this It should be safe to remove the concurrency setting as we dont have to handle the termination at the Github level which is causing the termination of post merge actions.#18283 (comment)Related Issues
Found when working as part of #17974
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.