[Flaky Test] Fix Flaky SearchServiceTests.testConcurrentSegmentSearchWithRandomizedModeSettings #18301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkewwei
requested review from
a team,
Bukhtawar,
CEHENKLE,
Rishikesh1159,
VachaShah,
anasalkouz,
andrross,
ashking94,
cwperks,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
owaiskazi19,
reta,
sachinpkale,
saratvemulapalli,
shwetathareja and
sohami
as code owners
github-actions
bot
added
>test-failure
Contributor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18301 +/- ##
============================================
- Coverage 72.51% 72.43% -0.08%
+ Complexity 67379 67330 -49
============================================
Files 5488 5488
Lines 311062 311062
Branches 45217 45217
============================================
- Hits 225552 225319 -233
- Misses 67132 67367 +235
+ Partials 18378 18376 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jed326
reviewed
May 15, 2025
server/src/test/java/org/opensearch/search/SearchServiceTests.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@jed326 Test case without aggregation has been added, please review when you are free. |
…dModeSettings Signed-off-by: kkewwei <kewei.11@bytedance.com> Signed-off-by: kkewwei <kkewwei@163.com>
Contributor
jed326
approved these changes
May 15, 2025
This was referenced May 15, 2025
jed326
pushed a commit
that referenced
this pull request
May 15, 2025
…dModeSettings (#18301) (#18308) (cherry picked from commit 8a847f2) Signed-off-by: kkewwei <kewei.11@bytedance.com> Signed-off-by: kkewwei <kkewwei@163.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
tanik98
pushed a commit
to tanik98/OpenSearch
that referenced
this pull request
May 27, 2025
…dModeSettings (opensearch-project#18301) Signed-off-by: kkewwei <kewei.11@bytedance.com> Signed-off-by: kkewwei <kkewwei@163.com>
tandonks
pushed a commit
to tandonks/OpenSearch
that referenced
this pull request
Jun 1, 2025
…dModeSettings (opensearch-project#18301) Signed-off-by: kkewwei <kewei.11@bytedance.com> Signed-off-by: kkewwei <kkewwei@163.com>
neuenfeldttj
pushed a commit
to neuenfeldttj/OpenSearch
that referenced
this pull request
Jun 26, 2025
…dModeSettings (opensearch-project#18301) Signed-off-by: kkewwei <kewei.11@bytedance.com> Signed-off-by: kkewwei <kkewwei@163.com>Signed-off-by: TJ Neuenfeldt <tjneu@amazon.com>
neuenfeldttj
pushed a commit
to neuenfeldttj/OpenSearch
that referenced
this pull request
Jun 26, 2025
…dModeSettings (opensearch-project#18301) Signed-off-by: kkewwei <kewei.11@bytedance.com> Signed-off-by: kkewwei <kkewwei@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously the default value was false, it had nothing to do with aggregation. Now default value is auto in case mode setting is not set, it is also decided by aggregationSupportsConcurrent, We should take aggregationSupportsConcurrent into account.
Related Issues
Resolves #18238
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.