-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Fix Dockerfile in repository s3 to use JDK 21 #18824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Dockerfile in repository s3 to use JDK 21 #18824
Conversation
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
|
For other Dockerfiles I see the change was added as part of this PR https://github.com/opensearch-project/OpenSearch/pull/16366/files. |
|
LGTM we can merge once the CI's are green. |
|
❌ Gradle check result for a8cb6d9: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for a8cb6d9: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for a8cb6d9: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❕ Gradle check result for a8cb6d9: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18824 +/- ##
============================================
+ Coverage 72.75% 72.87% +0.12%
- Complexity 68512 68600 +88
============================================
Files 5570 5570
Lines 314989 314989
Branches 45696 45696
============================================
+ Hits 229165 229557 +392
+ Misses 67240 66813 -427
- Partials 18584 18619 +35 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
* Fix Dockerfile in repository s3 to use JDK 21 Signed-off-by: Craig Perkins <cwperx@amazon.com> * Remove other image tag Signed-off-by: Craig Perkins <cwperx@amazon.com> --------- Signed-off-by: Craig Perkins <cwperx@amazon.com>
* Fix Dockerfile in repository s3 to use JDK 21 Signed-off-by: Craig Perkins <cwperx@amazon.com> * Remove other image tag Signed-off-by: Craig Perkins <cwperx@amazon.com> --------- Signed-off-by: Craig Perkins <cwperx@amazon.com>
Description
I ran into issues trying to run tests for the repository-s3 module from my mac due to the test fixture trying to use a version of java (JDK11) that was not compatible with OpenSearch 3.x (min compatibility JDK21).
This PR updates the Dockerfile to Ubuntu 22.04 and OpenJDK 21.
Verified I can run a test:
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.