Skip to content

Conversation

@cwperks
Copy link
Member

@cwperks cwperks commented Jul 23, 2025

Description

I ran into issues trying to run tests for the repository-s3 module from my mac due to the test fixture trying to use a version of java (JDK11) that was not compatible with OpenSearch 3.x (min compatibility JDK21).

This PR updates the Dockerfile to Ubuntu 22.04 and OpenJDK 21.

Verified I can run a test:

amazon_s3_access_key_temporary=$AWS_ACCESS_KEY_ID amazon_s3_secret_key_temporary=$AWS_SECRET_ACCESS_KEY amazon_s3_session_token_temporary=$AWS_SESSION_TOKEN amazon_s3_base_path_temporary=path amazon_s3_bucket_temporary=cwperx-opensearch amazon_s3_region_temporary=us-west-2 ./gradlew ':plugins:repository-s3:yamlRestTest' --tests 'org.opensearch.repositories.s3.RepositoryS3ClientYamlTestSuiteIT.test {yaml=repository_s3/20_repository_permanent_credentials/Register a read-only repository with a non existing bucket}'

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks cwperks requested a review from a team as a code owner July 23, 2025 18:54
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@prudhvigodithi
Copy link
Member

For other Dockerfiles I see the change was added as part of this PR https://github.com/opensearch-project/OpenSearch/pull/16366/files.

@prudhvigodithi
Copy link
Member

LGTM we can merge once the CI's are green.

@github-actions
Copy link
Contributor

❌ Gradle check result for a8cb6d9: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❌ Gradle check result for a8cb6d9: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❌ Gradle check result for a8cb6d9: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❕ Gradle check result for a8cb6d9: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@codecov
Copy link

codecov bot commented Jul 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.87%. Comparing base (04bf3cb) to head (a8cb6d9).
Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #18824      +/-   ##
============================================
+ Coverage     72.75%   72.87%   +0.12%     
- Complexity    68512    68600      +88     
============================================
  Files          5570     5570              
  Lines        314989   314989              
  Branches      45696    45696              
============================================
+ Hits         229165   229557     +392     
+ Misses        67240    66813     -427     
- Partials      18584    18619      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cwperks cwperks merged commit c1dfa6a into opensearch-project:main Jul 24, 2025
39 of 47 checks passed
tandonks pushed a commit to tandonks/OpenSearch that referenced this pull request Aug 5, 2025
* Fix Dockerfile in repository s3 to use JDK 21

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Remove other image tag

Signed-off-by: Craig Perkins <cwperx@amazon.com>

---------

Signed-off-by: Craig Perkins <cwperx@amazon.com>
vinaykpud pushed a commit to vinaykpud/OpenSearch that referenced this pull request Sep 26, 2025
* Fix Dockerfile in repository s3 to use JDK 21

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Remove other image tag

Signed-off-by: Craig Perkins <cwperx@amazon.com>

---------

Signed-off-by: Craig Perkins <cwperx@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants