Skip to content

Conversation

@cwperks
Copy link
Member

@cwperks cwperks commented Aug 7, 2025

Description

Whenever I run ./gradlew localDistro I see the following banner as the first output:

========================= WARNING =========================
         Backwards compatibility tests are disabled!
See https://github.com/opensearch-project/OpenSearch/issues/4173
===========================================================

This banner refers to a now closed github issue: #4173

I am able to run BWC tests from my mac. Example command: ./gradlew qa:full-cluster-restart:'v3.1.0#bwcTest'

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks cwperks requested a review from a team as a code owner August 7, 2025 23:58
@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2025

❌ Gradle check result for 6722e1a: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2025

✅ Gradle check result for 6722e1a: SUCCESS

@codecov
Copy link

codecov bot commented Aug 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.91%. Comparing base (f967a72) to head (25083c8).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #18983      +/-   ##
============================================
- Coverage     72.96%   72.91%   -0.05%     
+ Complexity    69451    69401      -50     
============================================
  Files          5645     5645              
  Lines        318787   318787              
  Branches      46125    46125              
============================================
- Hits         232610   232457     -153     
- Misses        67358    67561     +203     
+ Partials      18819    18769      -50     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@sandeshkr419 sandeshkr419 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
There is a minor typo on L254 if you can address in the same file!

@github-actions
Copy link
Contributor

✅ Gradle check result for 3d1f5d3: SUCCESS

Signed-off-by: Craig Perkins <cwperx@amazon.com>
@andrross andrross changed the title Remove banner about bwc tests being disabled on mac Enable backward compatibility tests on Mac Aug 12, 2025
@github-actions
Copy link
Contributor

✅ Gradle check result for 25083c8: SUCCESS

@cwperks cwperks merged commit a6b6ded into opensearch-project:main Aug 12, 2025
32 checks passed
RajatGupta02 pushed a commit to RajatGupta02/OpenSearch that referenced this pull request Aug 18, 2025
* Remove banner about bwc tests being disabled on mac

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Add to CHANGELOG and fix existing typo

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Update CHANGELOG entry

Signed-off-by: Craig Perkins <cwperx@amazon.com>

---------

Signed-off-by: Craig Perkins <cwperx@amazon.com>
atris pushed a commit to atris/OpenSearch that referenced this pull request Aug 28, 2025
* Remove banner about bwc tests being disabled on mac

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Add to CHANGELOG and fix existing typo

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Update CHANGELOG entry

Signed-off-by: Craig Perkins <cwperx@amazon.com>

---------

Signed-off-by: Craig Perkins <cwperx@amazon.com>
kh3ra pushed a commit to kh3ra/OpenSearch that referenced this pull request Sep 5, 2025
* Remove banner about bwc tests being disabled on mac

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Add to CHANGELOG and fix existing typo

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Update CHANGELOG entry

Signed-off-by: Craig Perkins <cwperx@amazon.com>

---------

Signed-off-by: Craig Perkins <cwperx@amazon.com>
vinaykpud pushed a commit to vinaykpud/OpenSearch that referenced this pull request Sep 26, 2025
* Remove banner about bwc tests being disabled on mac

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Add to CHANGELOG and fix existing typo

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Update CHANGELOG entry

Signed-off-by: Craig Perkins <cwperx@amazon.com>

---------

Signed-off-by: Craig Perkins <cwperx@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants