-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Enable backward compatibility tests on Mac #18983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Craig Perkins <cwperx@amazon.com>
|
❌ Gradle check result for 6722e1a: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #18983 +/- ##
============================================
- Coverage 72.96% 72.91% -0.05%
+ Complexity 69451 69401 -50
============================================
Files 5645 5645
Lines 318787 318787
Branches 46125 46125
============================================
- Hits 232610 232457 -153
- Misses 67358 67561 +203
+ Partials 18819 18769 -50 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sandeshkr419
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There is a minor typo on L254 if you can address in the same file!
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
* Remove banner about bwc tests being disabled on mac Signed-off-by: Craig Perkins <cwperx@amazon.com> * Add to CHANGELOG and fix existing typo Signed-off-by: Craig Perkins <cwperx@amazon.com> * Update CHANGELOG entry Signed-off-by: Craig Perkins <cwperx@amazon.com> --------- Signed-off-by: Craig Perkins <cwperx@amazon.com>
* Remove banner about bwc tests being disabled on mac Signed-off-by: Craig Perkins <cwperx@amazon.com> * Add to CHANGELOG and fix existing typo Signed-off-by: Craig Perkins <cwperx@amazon.com> * Update CHANGELOG entry Signed-off-by: Craig Perkins <cwperx@amazon.com> --------- Signed-off-by: Craig Perkins <cwperx@amazon.com>
* Remove banner about bwc tests being disabled on mac Signed-off-by: Craig Perkins <cwperx@amazon.com> * Add to CHANGELOG and fix existing typo Signed-off-by: Craig Perkins <cwperx@amazon.com> * Update CHANGELOG entry Signed-off-by: Craig Perkins <cwperx@amazon.com> --------- Signed-off-by: Craig Perkins <cwperx@amazon.com>
* Remove banner about bwc tests being disabled on mac Signed-off-by: Craig Perkins <cwperx@amazon.com> * Add to CHANGELOG and fix existing typo Signed-off-by: Craig Perkins <cwperx@amazon.com> * Update CHANGELOG entry Signed-off-by: Craig Perkins <cwperx@amazon.com> --------- Signed-off-by: Craig Perkins <cwperx@amazon.com>
Description
Whenever I run
./gradlew localDistroI see the following banner as the first output:This banner refers to a now closed github issue: #4173
I am able to run BWC tests from my mac. Example command:
./gradlew qa:full-cluster-restart:'v3.1.0#bwcTest'Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.