Fix flaky CompletionStatsCacheTests.testCompletionStatsCache #19076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atris
requested review from
a team,
Bukhtawar,
CEHENKLE,
Rishikesh1159,
VachaShah,
anasalkouz,
andrross,
ashking94,
cwperks,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
owaiskazi19,
reta,
sachinpkale,
saratvemulapalli,
shwetathareja and
sohami
as code owners
github-actions
bot
added
>test-failure
andrross
approved these changes
Aug 14, 2025
Contributor
|
❌ Gradle check result for 90e2d75: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Member
|
@atris Can you rebase to get the fix for the failing tests? |
This was referenced Aug 14, 2025
The test had a race condition where threads were calling start() twice on the CyclicBarrier - once inside getStats() and once from the main thread. This caused inconsistent synchronization and intermittent failures. Fixed by separating barrier synchronization from stats retrieval. Threads now explicitly call start() to wait on the barrier, then call getStatsOnly() to retrieve stats without additional synchronization. Fixes opensearch-project#18682 Signed-off-by: Atri Sharma <atri.jiit@gmail.com> #The test used a CyclicBarrier with 7 parties (6 threads + main thread) #which created unnecessary complexity. The main thread's participation in #the barrier was not needed and could cause timing issues. #Fixed by having only the 6 worker threads participate in the barrier for #synchronization. The main thread now simply starts the threads and waits #for them to complete via join(). This simplifies the synchronization model #and eliminates potential race conditions. #Fixes opensearch-project#18682
Contributor
Author
Done, thank you! |
Contributor
|
❌ Gradle check result for 57be3b6: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Contributor
|
❌ Gradle check result for 57be3b6: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Contributor
|
Flaky test: |
jainankitk
approved these changes
Aug 14, 2025
Contributor
|
❌ Gradle check result for 57be3b6: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19076 +/- ##
============================================
- Coverage 72.98% 72.83% -0.16%
+ Complexity 69482 69402 -80
============================================
Files 5647 5647
Lines 319137 319137
Branches 46163 46163
============================================
- Hits 232907 232428 -479
- Misses 67391 67897 +506
+ Partials 18839 18812 -27 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
RajatGupta02
pushed a commit
to RajatGupta02/OpenSearch
that referenced
this pull request
Aug 18, 2025
…rch-project#19076) The test had a race condition where threads were calling start() twice on the CyclicBarrier - once inside getStats() and once from the main thread. This caused inconsistent synchronization and intermittent failures. Fixed by separating barrier synchronization from stats retrieval. Threads now explicitly call start() to wait on the barrier, then call getStatsOnly() to retrieve stats without additional synchronization. Fixes opensearch-project#18682 Signed-off-by: Atri Sharma <atri.jiit@gmail.com>
karenyrx
pushed a commit
to karenyrx/OpenSearch
that referenced
this pull request
Aug 21, 2025
…rch-project#19076) The test had a race condition where threads were calling start() twice on the CyclicBarrier - once inside getStats() and once from the main thread. This caused inconsistent synchronization and intermittent failures. Fixed by separating barrier synchronization from stats retrieval. Threads now explicitly call start() to wait on the barrier, then call getStatsOnly() to retrieve stats without additional synchronization. Fixes opensearch-project#18682 Signed-off-by: Atri Sharma <atri.jiit@gmail.com>
atris
added a commit
to atris/OpenSearch
that referenced
this pull request
Aug 28, 2025
…rch-project#19076) The test had a race condition where threads were calling start() twice on the CyclicBarrier - once inside getStats() and once from the main thread. This caused inconsistent synchronization and intermittent failures. Fixed by separating barrier synchronization from stats retrieval. Threads now explicitly call start() to wait on the barrier, then call getStatsOnly() to retrieve stats without additional synchronization. Fixes opensearch-project#18682 Signed-off-by: Atri Sharma <atri.jiit@gmail.com>
kh3ra
pushed a commit
to kh3ra/OpenSearch
that referenced
this pull request
Sep 5, 2025
…rch-project#19076) The test had a race condition where threads were calling start() twice on the CyclicBarrier - once inside getStats() and once from the main thread. This caused inconsistent synchronization and intermittent failures. Fixed by separating barrier synchronization from stats retrieval. Threads now explicitly call start() to wait on the barrier, then call getStatsOnly() to retrieve stats without additional synchronization. Fixes opensearch-project#18682 Signed-off-by: Atri Sharma <atri.jiit@gmail.com>
vinaykpud
pushed a commit
to vinaykpud/OpenSearch
that referenced
this pull request
Sep 26, 2025
…rch-project#19076) The test had a race condition where threads were calling start() twice on the CyclicBarrier - once inside getStats() and once from the main thread. This caused inconsistent synchronization and intermittent failures. Fixed by separating barrier synchronization from stats retrieval. Threads now explicitly call start() to wait on the barrier, then call getStatsOnly() to retrieve stats without additional synchronization. Fixes opensearch-project#18682 Signed-off-by: Atri Sharma <atri.jiit@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test had a race condition where threads were calling start() twice
on the CyclicBarrier - once inside getStats() and once from the main
thread. This caused inconsistent synchronization and intermittent failures.
Fixed by separating barrier synchronization from stats retrieval. Threads
now explicitly call start() to wait on the barrier, then call getStatsOnly()
to retrieve stats without additional synchronization.
Fixes #18682
Signed-off-by: Atri Sharma atri.jiit@gmail.com
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.