Handling concurrent segment search as part of fetch profiling #19164
Conversation
Signed-off-by: Ankit Jain <jain.ankitk@gmail.com>
jainankitk
requested review from
a team,
Bukhtawar,
CEHENKLE,
Rishikesh1159,
VachaShah,
anasalkouz,
andrross,
ashking94,
cwperks,
dbwiddis,
gbbafna,
jed326,
kotwanikunal,
mch2,
msfroh,
owaiskazi19,
reta,
sachinpkale,
saratvemulapalli,
shwetathareja and
sohami
as code owners
github-actions
bot
added
>test-failure
|
❌ Gradle check result for fb0429a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for fb0429a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for fb0429a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
server/src/main/java/org/opensearch/search/profile/fetch/FlatFetchProfileTree.java
Show resolved
Hide resolved
|
❕ Gradle check result for 5fad82b: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19164 +/- ##
============================================
+ Coverage 72.80% 72.92% +0.12%
- Complexity 69599 69692 +93
============================================
Files 5656 5656
Lines 320002 320002
Branches 46338 46338
============================================
+ Hits 232968 233362 +394
+ Misses 68140 67746 -394
Partials 18894 18894 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…arch-project#19164) Signed-off-by: Ankit Jain <jain.ankitk@gmail.com>
…arch-project#19164) Signed-off-by: Ankit Jain <jain.ankitk@gmail.com>
…arch-project#19164) Signed-off-by: Ankit Jain <jain.ankitk@gmail.com>
…arch-project#19164) Signed-off-by: Ankit Jain <jain.ankitk@gmail.com> Signed-off-by: Ankit Jain <jainankitk@apache.org>
…arch-project#19164) Signed-off-by: Ankit Jain <jain.ankitk@gmail.com> Signed-off-by: Ankit Jain <jainankitk@apache.org>
…arch-project#19164) Signed-off-by: Ankit Jain <jain.ankitk@gmail.com>
…arch-project#19164) Signed-off-by: Ankit Jain <jain.ankitk@gmail.com>
2 participants
Description
During fetch phase profiling,
FlatFetchProfileTreeobject is shared across multiple threads and the state needs to be synchronized to prevent intermittent issues. co-author @atrisRelated Issues
Resolves #19070
Check List
- [] API changes companion pull request created, if applicable.- [ ] Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.