-
Notifications
You must be signed in to change notification settings - Fork 2.3k
[Rule-based Auto-tagging] Modify get rule api to suit nested attributes #19429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7b66b1d to
7a51365
Compare
modules/autotagging-commons/common/src/main/java/org/opensearch/rule/action/GetRuleRequest.java
Show resolved
Hide resolved
|
❕ Gradle check result for 7a51365: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #19429 +/- ##
============================================
- Coverage 73.00% 72.95% -0.05%
+ Complexity 70373 70337 -36
============================================
Files 5708 5708
Lines 322433 322460 +27
Branches 46695 46702 +7
============================================
- Hits 235385 235258 -127
- Misses 68066 68216 +150
- Partials 18982 18986 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
...mons/common/src/main/java/org/opensearch/rule/service/IndexStoredRulePersistenceService.java
Show resolved
Hide resolved
modules/autotagging-commons/common/src/main/java/org/opensearch/rule/RuleUtils.java
Outdated
Show resolved
Hide resolved
modules/autotagging-commons/common/src/main/java/org/opensearch/rule/RuleUtils.java
Outdated
Show resolved
Hide resolved
modules/autotagging-commons/common/src/main/java/org/opensearch/rule/RuleUtils.java
Show resolved
Hide resolved
|
❌ Gradle check result for e99f7bd: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>
|
❌ Gradle check result for 8e8d45b: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>
|
❕ Gradle check result for b076cea: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
…es (opensearch-project#19429) Signed-off-by: Ruirui Zhang <mariazrr@amazon.com>
Description
This PR enhances the
_rules/workload_groupGET API to support filtering by nested attributes in addition to top-level fields. Previously, users could filter only by top-level attributes, such asindex_pattern. With this update, the API now supports filtering on nested attributes likeprincipal.usernameandprincipal.role.Examples
Previously it supports:
Returns all rules with index_pattern matching the prefix my-index.
Now it also supports nested attribute filter:
Returns all rules where principal.username equals admin and principal.role equals a.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.