Fix Unified highlighter for nested fields when using matchPhrasePrefixQuery

[sjs004]

Description

CustomUnifiedHighlighter.rewriteCustomQuery() wasn't handling nested query (internally written as OpenSearchToParentBlockJoinQuery). Therefore unified highlighter wasn't working. Added the missing handling & updated tests

Related Issues

Resolves #19106

Check List

• Functionality includes testing.
• API changes companion pull request created, if applicable.
• Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

❌ Gradle check result for d61fbdb: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for 17794cc: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for bf35e4b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[sandeshkr419]

Some indentation failures @sjs004.

Run './gradlew :server:spotlessApply' to fix these violations.

[github-actions]

❌ Gradle check result for a0ad332: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[sjs004]

@sandeshkr419 There is a failing test (org.opensearch.action.admin.cluster.filecache.PruneFileCacheIT.testPruneCacheWithRealData). Let me check it. Doesn't seem related to my change though. Maybe a flaky test

Update: It passed locally so it's a flaky test

#19724

[github-actions]

❌ Gradle check result for 5fbbc66: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for 13a511d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

❌ Gradle check result for 13a511d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

✅ Gradle check result for 3fc81c4: SUCCESS

[sandeshkr419]

Looks good! Thanks for working on this and adding up test cases for full coverage!

[sjs004]

Thanks @sandeshkr419 . Finally all checks have passed. I actually had to retry pipeline multiple times due to flaky tests & sometimes jenkins job for gradle-check not starting

[sandeshkr419]

Yeah, I guess the CI was throttled up and required manual approvals to continue.

[sjs004]

@sandeshkr419 I think wait time for Jenkins job parse error can be reduced from 2 hours. It is currently 2 hours, same as wait time for status check. Usually people may assume that tests are running but in reality the job itself didn't trigger

[sandeshkr419]

I think wait time for Jenkins job parse error can be reduced from 2 hours. It is currently 2 hours, same as wait time for status check. Usually people may assume that tests are running but in reality the job itself didn't trigger

@gaiksaya, @rishabh6788 - Do you think there is an opportunity to improve this?