Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Remove] Type mapping parameter from put index mappings API #2222

Closed
wants to merge 4 commits into from
Closed

[Remove] Type mapping parameter from put index mappings API #2222

wants to merge 4 commits into from

Conversation

dreamer-89
Copy link
Member

@dreamer-89 dreamer-89 commented Feb 23, 2022 •
edited
Loading

Description

With types deprecation, this change removes type mapping API end-points for put index mappings API end-point.

Relates #1940

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dreamer-89
[Remove] Type mapping from index get mapping API
22b0f5f 
Signed-off-by: Suraj Singh <surajrider@gmail.com>
@dreamer-89
Fix integration tests failures
65618fb 
Signed-off-by: Suraj Singh <surajrider@gmail.com>
@dreamer-89
[Remove] Type mapping from index put mapping API
33b06ee 
Signed-off-by: Suraj Singh <surajrider@gmail.com>
@dreamer-89
Fix integration tests failures
08ca5dc 
Signed-off-by: Suraj Singh <surajrider@gmail.com>
@dreamer-89 dreamer-89 requested a review from a team as a code owner February 23, 2022 01:08
@dreamer-89 dreamer-89 mentioned this pull request Feb 23, 2022
Closed
67 tasks
@dreamer-89
Copy link
Member Author

Needs rebase against main once #2220 is merged

@opensearch-ci-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 08ca5dc
Log 2726

Reports 2726

reta
reta reviewed Feb 23, 2022
View reviewed changes
...i-spec/src/main/resources/rest-api-spec/test/indices.put_mapping/20_mix_typeless_typeful.yml
@@ -41,7 +38,6 @@
- do:
catch: /the final mapping would have more than 1 type/
indices.put_mapping:
include_type_name: true
index: index
type: some_other_type
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The presence of type seems to be not right, it should not be used, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@reta : Thanks for pointing this out. This also explains the existing test failures.

@dreamer-89
Copy link
Member Author

dreamer-89 commented Feb 23, 2022 •
edited
Loading

Removal of type from rest end-points cause failures in yaml rest api tests because of validation checks on non-empty type in PutMappingRequest class. This mandates either adding back a dummy _doc type in put APIs or remove all internal references of type (and validations) in internal classes. In order to avoid rework (adding back dummy _doc type), I will remove all internal references of type as part of this PR.

@dreamer-89
Copy link
Member Author

Resolved in #2238

@dreamer-89 dreamer-89 closed this Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reta reta reta left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dreamer-89 @opensearch-ci-bot @reta