Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Rename] ESTestCase stragglers to OpenSearchTestCase #3053

Merged
merged 1 commit into from
Apr 23, 2022
Merged

[Rename] ESTestCase stragglers to OpenSearchTestCase #3053

merged 1 commit into from
Apr 23, 2022

Conversation

nknize
Copy link
Collaborator

@nknize nknize commented Apr 23, 2022

A few places still referenced legacy ESTestCase naming. This refactors those
instances to OpenSearchTestCase.

@nknize
[Cleanup] Rename ESTestCase stragglers to OpenSearchTestCase
0dc319a 
A few places still referenced legacy ESTestCase name. This refactors those
instances to OpenSearchTestCase.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
@nknize nknize added Rename Renaming to OpenSearch non-issue bugs / unexpected behaviors that end up non issues; audit trail simple changes that aren't issues v3.0.0 Issues and PRs related to version 3.0.0 labels Apr 23, 2022
@nknize nknize requested review from a team and reta as code owners April 23, 2022 06:14
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 0dc319a
Log 4746

Reports 4746

@reta
Copy link
Collaborator

reta commented Apr 23, 2022

❌ Gradle Check failure 0dc319a Log 4746

Reports 4746

@nknize seems like we hit #3046 again:

org.opensearch.search.aggregations.bucket.MinDocCountIT > testHistogramKeyAsc FAILED
    com.carrotsearch.randomizedtesting.UncaughtExceptionError: Captured an uncaught exception in thread: Thread[id=1292, name=opensearch[node_s0][search][T#7], state=RUNNABLE, group=TGRP-MinDocCountIT]
        at __randomizedtesting.SeedInfo.seed([DD81173F0D460702:90D539D9A783DDD4]:0)

        Caused by:
        java.lang.AssertionError: No thread should be marked active when task finishes
            at __randomizedtesting.SeedInfo.seed([DD81173F0D460702]:0)
            at org.opensearch.tasks.TaskResourceTrackingService.stopTracking(TaskResourceTrackingService.java:117)
            at org.opensearch.tasks.TaskManager.unregister(TaskManager.java:214)
            at org.opensearch.action.support.TransportAction$1.lambda$onResponse$0(TransportAction.java:106)
            at org.opensearch.core.internal.io.IOUtils.close(IOUtils.java:87)
            at org.opensearch.core.internal.io.IOUtils.close(IOUtils.java:129)

@nknize
Copy link
Collaborator Author

nknize commented Apr 23, 2022

seems like we hit #3046 again

Starting gradle check again and we'll see how often this recurs. If it's pathological we won't wait any longer to commit #3046.

@nknize
Copy link
Collaborator Author

nknize commented Apr 23, 2022

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 0dc319a
Log 4752

Reports 4752

@nknize nknize merged commit 88bc268 into opensearch-project:main Apr 23, 2022
@nknize nknize added backport 2.x Backport to 2.x branch backport 2.0 Backport to 2.0 branch labels Apr 25, 2022
This was referenced Apr 25, 2022
Merged
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 25, 2022
@nknize @github-actions
[Rename] ESTestCase stragglers to OpenSearchTestCase (#3053)
05d192a 
A few places still referenced legacy ESTestCase name. This refactors those
instances to OpenSearchTestCase.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
(cherry picked from commit 88bc268)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 25, 2022
@nknize @github-actions
[Rename] ESTestCase stragglers to OpenSearchTestCase (#3053)
7002a2f 
A few places still referenced legacy ESTestCase name. This refactors those
instances to OpenSearchTestCase.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
(cherry picked from commit 88bc268)
nknize added a commit that referenced this pull request Apr 25, 2022
@nknize
[Rename] ESTestCase stragglers to OpenSearchTestCase (#3053)
3291b3c 
A few places still referenced legacy ESTestCase name. This refactors those
instances to OpenSearchTestCase.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
(cherry picked from commit 88bc268)
nknize added a commit that referenced this pull request Apr 25, 2022
@nknize
[Rename] ESTestCase stragglers to OpenSearchTestCase (#3053)
d985366 
A few places still referenced legacy ESTestCase name. This refactors those
instances to OpenSearchTestCase.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
(cherry picked from commit 88bc268)
nknize added a commit that referenced this pull request Apr 25, 2022
@opensearch-trigger-bot @nknize
[Rename] ESTestCase stragglers to OpenSearchTestCase (#3053) (#3064)
15d129a 
A few places still referenced legacy ESTestCase name. This refactors those
instances to OpenSearchTestCase.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
(cherry picked from commit 88bc268)

Co-authored-by: Nick Knize <nknize@apache.org>
nknize added a commit that referenced this pull request Apr 25, 2022
@opensearch-trigger-bot @nknize
[Rename] ESTestCase stragglers to OpenSearchTestCase (#3053) (#3065)
a483f92 
A few places still referenced legacy ESTestCase name. This refactors those
instances to OpenSearchTestCase.

Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
(cherry picked from commit 88bc268)

Co-authored-by: Nick Knize <nknize@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owaiskazi19 owaiskazi19 owaiskazi19 approved these changes

@reta reta reta approved these changes

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch backport 2.0 Backport to 2.0 branch non-issue bugs / unexpected behaviors that end up non issues; audit trail simple changes that aren't issues Rename Renaming to OpenSearch v3.0.0 Issues and PRs related to version 3.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nknize @opensearch-ci-bot @reta @owaiskazi19