Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump antlr4-runtime from 4.9.3 to 4.10.1 in /modules/lang-expression #3059

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 25, 2022

Bumps antlr4-runtime from 4.9.3 to 4.10.1.

Release notes

Sourced from antlr4-runtime's releases.

4.10.1

Tiny update to fix build issue where java requirement for runtime was 11 not 1.8.

What's Changed

Full Changelog: antlr/antlr4@v4.10.0...4.10.1

4.10 Major feature, code clean up, and bug fix release

ANTLR version 4.10

This is a very major release with a number of important changes. There have been many valuable contributions, but I welcome @​KvanTTT and @​jcking as recent "official" major ANTLR contributors. :)

WARNING: Generated 4.10 lexers and parsers are incompatible with code generated by previous versions of ANTLR. You must regenerate all of your code from grammars to use the new runtime. This is true of all targets (except probably javascript).

Repo branching structure

We have changed the branching structure of the repository. The default branch for this repo remains master and it is the latest stable release with tags for the various releases; e.g., see release tag 4.9.3. We now do development work in branch dev between releases and all pull requests should be derived from that branch. The dev branch is merged back into master to cut a release and the release state is tagged (e.g., with 4.10-rc.1 or 4.10.) Visually our process looks roughly like this:

Targets such as Go that pull directly from the repository can use the default master branch but can also pull from the active dev branch:

$ go get github.com/antlr/antlr4/runtime/Go/antlr@dev

Developers certificate of origin

In order to bring ANTLR more in line with current standard standards for contribution processes, as of 4.10, ANTLR uses the Linux Foundation's Developer Certificate of Origin, DCO, version 1.1. See file https://github.com/antlr/antlr4/raw/master/developer-cert-of-origin.txt . It is simpler than the original contributors license agreement, which required programmers to sign the contributors.txt file, which has now moved to file historical-contributors-agreement.txt .

Each commit in pull requests must have a "signature", which is simple as using -s (not -S) on the git commit command:

$ git commit -s -m 'This is my commit message'

Github's pull request process enforces the sig and gives instructions on how to fix any commits that lack the sig. See https://github.com/apps/dco for more info.

4.10-generated parsers incompatible with previous runtimes

ANTLR not only generates recursive-descent parsers; it generates a state machine called an augmented transition network (ATN) in serialized form as a bunch of integers stored in the generated parser and lexer files. This serialization format was changed for 4.10 to remove a size limit on the supported ATNs. See antlr/antlr4#3591.

The key point here is that we changed the version number stored inside the serialization format and so, in order to use this new version of ANTLR, you must regenerate all of your lexers and parsers using the 4.10 tool and then use the new runtime. Parsers generated with 4.10 or not compatible with previous versions of the runtime.

Increasing minimum java version

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested review from a team and reta as code owners April 25, 2022 13:26
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Apr 25, 2022
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 60afde1
Log 4767

Reports 4767

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure b2d9480
Log 4771

Reports 4771

@nknize
Copy link
Collaborator

nknize commented Apr 25, 2022

Another #3046 failure:

    com.carrotsearch.randomizedtesting.UncaughtExceptionError: Captured an uncaught exception in thread: Thread[id=52, name=opensearch[node_s0][transport_worker][T#2], state=RUNNABLE, group=TGRP-ReindexVersioningTests]

        Caused by:
        java.lang.AssertionError: No thread should be marked active when task finishes
            at __randomizedtesting.SeedInfo.seed([71C3323DFAB7EB15]:0)
            at org.opensearch.tasks.TaskResourceTrackingService.stopTracking(TaskResourceTrackingService.java:117)
            at org.opensearch.tasks.TaskManager.unregister(TaskManager.java:214)
            at org.opensearch.action.support.TransportAction$1.lambda$onResponse$0(TransportAction.java:106)

@nknize
Copy link
Collaborator

nknize commented Apr 25, 2022

Looks like this will also need manual intervention:

REPRODUCE WITH: ./gradlew ':modules:lang-expression:test' --tests "org.opensearch.script.expression.ExpressionNumberSortScriptTests.testLinkError" -Dtests.seed=71C3323DFAB7EB15 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=mt -Dtests.timezone=Etc/GMT+9 -Druntime.java=17
org.opensearch.script.expression.ExpressionNumberSortScriptTests > testLinkError FAILED
    junit.framework.AssertionFailedError: Unexpected exception type, expected ScriptException but got java.lang.ExceptionInInitializerError
        at __randomizedtesting.SeedInfo.seed([71C3323DFAB7EB15:209F793FF594B58B]:0)
        at org.apache.lucene.tests.util.LuceneTestCase.expectThrows(LuceneTestCase.java:2904)
        at org.apache.lucene.tests.util.LuceneTestCase.expectThrows(LuceneTestCase.java:2885)
        at org.opensearch.script.expression.ExpressionNumberSortScriptTests.testLinkError(ExpressionNumberSortScriptTests.java:93)

        Caused by:
        java.lang.ExceptionInInitializerError
            at org.apache.lucene.expressions.js.JavascriptCompiler.getAntlrParseTree(JavascriptCompiler.java:235)
            at org.apache.lucene.expressions.js.JavascriptCompiler.compileExpression(JavascriptCompiler.java:206)
            at org.apache.lucene.expressions.js.JavascriptCompiler.compile(JavascriptCompiler.java:158)
            at org.opensearch.script.expression.ExpressionScriptEngine$7.run(ExpressionScriptEngine.java:198)
            at org.opensearch.script.expression.ExpressionScriptEngine$7.run(ExpressionScriptEngine.java:177)
            at java.base/java.security.AccessController.doPrivileged(AccessController.java:318)
            at org.opensearch.script.expression.ExpressionScriptEngine.compile(ExpressionScriptEngine.java:177)
            at org.opensearch.script.expression.ExpressionNumberSortScriptTests.compile(ExpressionNumberSortScriptTests.java:83)
            at org.opensearch.script.expression.ExpressionNumberSortScriptTests.lambda$testLinkError$2(ExpressionNumberSortScriptTests.java:93)
            at org.apache.lucene.tests.util.LuceneTestCase._expectThrows(LuceneTestCase.java:3057)
            at org.apache.lucene.tests.util.LuceneTestCase.expectThrows(LuceneTestCase.java:2894)
            ... 2 more

            Caused by:
            java.lang.UnsupportedOperationException: java.io.InvalidClassException: org.antlr.v4.runtime.atn.ATN; Could not deserialize ATN with version 3 (expected 4).
                at org.antlr.v4.runtime.atn.ATNDeserializer.deserialize(ATNDeserializer.java:56)
                at org.antlr.v4.runtime.atn.ATNDeserializer.deserialize(ATNDeserializer.java:48)
                at org.apache.lucene.expressions.js.JavascriptLexer.<clinit>(JavascriptLexer.java:279)
                ... 13 more

                Caused by:
                java.io.InvalidClassException: org.antlr.v4.runtime.atn.ATN; Could not deserialize ATN with version 3 (expected 4).
                    at org.antlr.v4.runtime.atn.ATNDeserializer.deserialize(ATNDeserializer.java:56)
                    ... 15 more

Copy link
Collaborator

@nknize nknize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual intervention needed

@kartg
Copy link
Member

kartg commented May 3, 2022

Likely a similar case as #3056 (comment)

@kotwanikunal
Copy link
Member

@dependabot rebase

Bumps [antlr4-runtime](https://github.com/antlr/antlr4) from 4.9.3 to 4.10.1.
- [Release notes](https://github.com/antlr/antlr4/releases)
- [Changelog](https://github.com/antlr/antlr4/blob/master/CHANGES.txt)
- [Commits](antlr/antlr4@4.9.3...4.10.1)

---
updated-dependencies:
- dependency-name: org.antlr:antlr4-runtime
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/gradle/modules/lang-expression/org.antlr-antlr4-runtime-4.10.1 branch from b2d9480 to d54db07 Compare June 14, 2022 20:06
Signed-off-by: dependabot[bot] <support@github.com>
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure d54db07
Log 6000

Reports 6000

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 81aa6ee
Log 6002

Reports 6002

@kotwanikunal
Copy link
Member

This merge is blocked because of the same reason mentioned here - #3056 (comment)

@kartg kartg mentioned this pull request Aug 3, 2022
5 tasks
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 5, 2022

Superseded by #4413.

@dependabot dependabot bot closed this Sep 5, 2022
@dependabot dependabot bot deleted the dependabot/gradle/modules/lang-expression/org.antlr-antlr4-runtime-4.10.1 branch September 5, 2022 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants