Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Segment Replication] Add timeout on Mockito.verify to reduce flakyness in testReplicationOnDone test #4332

Closed
wants to merge 1 commit into from

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport f4e041e from #4314

…ss in testReplicationOnDone test (#4314)

* [Segment Replication] testReplicationOnDone Add timeout to allow time for verify call

Signed-off-by: Suraj Singh <surajrider@gmail.com>

* Update changelog

Signed-off-by: Suraj Singh <surajrider@gmail.com>

* Add change log entry

Signed-off-by: Suraj Singh <surajrider@gmail.com>

Signed-off-by: Suraj Singh <surajrider@gmail.com>
(cherry picked from commit f4e041e)
@opensearch-trigger-bot opensearch-trigger-bot bot requested review from a team and reta as code owners August 29, 2022 20:45
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov-commenter
Copy link

Codecov Report

Merging #4332 (e023834) into 2.x (38372e1) will increase coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                2.x    #4332      +/-   ##
============================================
+ Coverage     70.61%   70.66%   +0.04%     
+ Complexity    56935    56928       -7     
============================================
  Files          4571     4571              
  Lines        273530   273530              
  Branches      40111    40111              
============================================
+ Hits         193147   193280     +133     
+ Misses        64195    64051     -144     
- Partials      16188    16199      +11     
Impacted Files Coverage Δ
...search/indices/recovery/RecoveryTargetHandler.java 0.00% <0.00%> (-100.00%) ⬇️
...n/admin/cluster/node/tasks/get/GetTaskRequest.java 30.30% <0.00%> (-63.64%) ⬇️
...ava/org/opensearch/action/NoSuchNodeException.java 0.00% <0.00%> (-50.00%) ⬇️
...h/action/ingest/SimulateDocumentVerboseResult.java 60.71% <0.00%> (-39.29%) ⬇️
...java/org/opensearch/threadpool/ThreadPoolInfo.java 56.25% <0.00%> (-37.50%) ⬇️
.../admin/cluster/node/tasks/get/GetTaskResponse.java 28.57% <0.00%> (-35.72%) ⬇️
...regations/metrics/AbstractHyperLogLogPlusPlus.java 63.79% <0.00%> (-32.76%) ⬇️
.../search/aggregations/pipeline/HoltLinearModel.java 20.33% <0.00%> (-32.21%) ⬇️
...h/aggregations/bucket/terms/UnmappedRareTerms.java 21.05% <0.00%> (-26.32%) ⬇️
...pensearch/index/shard/SearchOperationListener.java 72.34% <0.00%> (-23.41%) ⬇️
... and 483 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dreamer-89
Copy link
Member

dreamer-89 commented Oct 6, 2022

Test testReplicationOnDone was removed in a different PR. So, this change is not needed anymore.

@Rishikesh1159 Rishikesh1159 deleted the backport/backport-4314-to-2.x branch October 6, 2022 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants