Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x]Add GeoBounds aggregation on GeoShape field type.(#3980) (#4266) #8301

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

heemin32
Copy link
Contributor

Description

Enables geo_bounds aggregation to work with geo_shape field types.

This enhancement includes:
* Addition of Doc values on the GeoShape Field.
* Addition of GeoShape ValueSource level code interfaces for accessing the DocValues.
* Addition of Missing Value feature in the GeoShape Aggregations.

Related Issues

Resolves #3980

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…3980) (opensearch-project#4266)

Enables geo_bounds aggregation to work with geo_shape field types.

This enhancement includes:
    * Addition of Doc values on the GeoShape Field.
    * Addition of GeoShape ValueSource level code interfaces for accessing the DocValues.
    * Addition of Missing Value feature in the GeoShape Aggregations.

Signed-off-by: Navneet Verma <navneev@amazon.com>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.search.SearchWeightedRoutingIT.testStrictWeightedRoutingWithCustomString
      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testPressureServiceStats

@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #8301 (5d35f5c) into 2.x (2dbe33f) will increase coverage by 0.01%.
The diff coverage is 64.49%.

@@             Coverage Diff              @@
##                2.x    #8301      +/-   ##
============================================
+ Coverage     70.54%   70.56%   +0.01%     
- Complexity    56776    56797      +21     
============================================
  Files          4706     4714       +8     
  Lines        269087   269420     +333     
  Branches      39773    39821      +48     
============================================
+ Hits         189836   190105     +269     
- Misses        62886    62943      +57     
- Partials      16365    16372       +7     
Impacted Files Coverage Δ
...va/org/opensearch/geometry/GeometryCollection.java 96.42% <0.00%> (+0.13%) ⬆️
...java/org/opensearch/index/fielddata/FieldData.java 70.48% <0.00%> (-3.11%) ⬇️
...rch/search/aggregations/support/MissingValues.java 79.56% <0.00%> (-6.91%) ⬇️
...rch/aggregations/support/CoreValuesSourceType.java 66.03% <17.64%> (-9.52%) ⬇️
...fielddata/plain/AbstractLeafGeoShapeFieldData.java 33.33% <33.33%> (ø)
.../java/org/opensearch/common/geo/ShapeDocValue.java 43.54% <43.54%> (ø)
...index/fielddata/plain/GeoShapeDVLeafFieldData.java 50.00% <50.00%> (ø)
...arch/search/aggregations/support/ValuesSource.java 84.44% <50.00%> (-3.06%) ⬇️
...va/org/opensearch/common/geo/GeoShapeDocValue.java 59.25% <59.25%> (ø)
...regations/metrics/GeoBoundsGeoShapeAggregator.java 72.91% <72.91%> (ø)
... and 6 more

... and 464 files with indirect coverage changes

Copy link
Collaborator

@nknize nknize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for backporting this!!

@nknize nknize merged commit ebe6f2c into opensearch-project:2.x Jun 28, 2023
@nknize nknize added feature New feature or request backport PRs or issues specific to backporting features or enhancments Geospatial labels Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PRs or issues specific to backporting features or enhancments feature New feature or request Geospatial v2.9.0 'Issues and PRs related to version v2.9.0'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants