-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] 2.3.0 build failed on Windows Agent #557
Comments
@praveensameneni @lezzago Can you please provide your inputs here? |
Just looks like a linter issue. The lines specified can be updated to not exceed the maximum to fix that error. Not sure why it hasn't failed in the CI before, are we skipping it there? @peterzhuamazon You can try excluding the task and seeing if it succeeds without it for now by adding |
looks like the issue is not reproducible on |
@peterzhuamazon , can we close this issue? |
Hi @praveensameneni Lets make sure disable ktlint wont cause any issues, or just fix it for windows before closing this. |
Also this only shows in the 2.3.0 not in 1.3.5 for alerting. |
According to this post seems like the 0.47.0 version of ktlint has fixed such issues: |
ktlint 0.47.0 logs
I test on 0.47.0 ktlint and it didnt fail with max-length but introduced a lot of different linting errors, which is expected. Thanks. |
We have already enabled long path support on this windows agent.
So it is not related to the 260 max char API issues on Windows.
It is something else that is similar to indentation formatting feature in kt I think.
The text was updated successfully, but these errors were encountered: