Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backport 1.3] update jackson dependency version (#678) #681

Merged
merged 1 commit into from
Oct 4, 2022
Merged

[backport 1.3] update jackson dependency version (#678) #681

merged 1 commit into from
Oct 4, 2022

Conversation

amitgalitz
Copy link
Member

Signed-off-by: Amit Galitzky amgalitz@amazon.com

Description

backport #678 to 1.3, auto backport PR failed

Issues Resolved

#676

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@amitgalitz
update jackson dependency version (opensearch-project#678)
7bf0b30 
Signed-off-by: Amit Galitzky <amgalitz@amazon.com>
@codecov-commenter
Copy link

Codecov Report

Merging #681 (7bf0b30) into 1.3 (effabc0) will decrease coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                1.3     #681      +/-   ##
============================================
- Coverage     77.83%   77.72%   -0.11%     
+ Complexity     4122     4117       -5     
============================================
  Files           296      296              
  Lines         17687    17687              
  Branches       1884     1884              
============================================
- Hits          13767    13748      -19     
- Misses         3017     3035      +18     
- Partials        903      904       +1
Flag Coverage Δ
plugin 77.72% <ø> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...java/org/opensearch/ad/task/ADBatchTaskRunner.java 80.54% <0.00%> (-2.89%) ⬇️
...ain/java/org/opensearch/ad/model/ModelProfile.java 70.90% <0.00%> (-1.82%) ⬇️
...ava/org/opensearch/ad/task/ADHCBatchTaskCache.java 88.88% <0.00%> (-1.24%) ⬇️
...ain/java/org/opensearch/ad/task/ADTaskManager.java 77.13% <0.00%> (+0.15%) ⬆️

@amitgalitz amitgalitz merged commit 09cbdbc into opensearch-project:1.3 Oct 4, 2022
kaituo added a commit to kaituo/anomaly-detection-1 that referenced this pull request Sep 8, 2023
@kaituo
Upgrade AD's bwc baseline version to 1.3.2 to resolve cluster join issue
bea81c8 
Issue:
- In versions between 1.1 and 2.10, the task :adBwcCluster#twoThirdsUpgradedClusterTask fails.
- Symptoms mirror those in [OpenSearch Issue #5076](opensearch-project/OpenSearch#5076).
- Logs show nodes from old and new versions failing to join as a cluster, resulting in a "master not found" exception.

Resolution:
- Upgraded the bwc version to 1.3.2, aligning with other plugins which use 1.3+ as their baseline.
  - [Cross-Cluster Replication PR opensearch-project#469](opensearch-project/cross-cluster-replication#469)
  - [Security PR #2253](opensearch-project/security#2253)
  - [ML Commons PR opensearch-project#681](opensearch-project/ml-commons#681)
- Post-upgrade, the twoThirdsUpgradedClusterTask runs successfully, suggesting potential incompatibility between versions 1.1 and 2.10.

Testing:
- Executed `./gradlew bwcTestSuite -Dtests.security.manager=false` and all tests passed.

Signed-off-by: Kaituo Li <kaituo@amazon.com>
kaituo added a commit to kaituo/anomaly-detection-1 that referenced this pull request Sep 8, 2023
@kaituo
Upgrade AD's bwc baseline version to 1.3.2 to resolve cluster join issue
b30fed2 
Issue:
- In versions between 1.1 and 2.10, the task :adBwcCluster#twoThirdsUpgradedClusterTask fails.
- Symptoms mirror those in [OpenSearch Issue #5076](opensearch-project/OpenSearch#5076).
- Logs show nodes from old and new versions failing to join as a cluster, resulting in a "master not found" exception.

Resolution:
- Upgraded the bwc version to 1.3.2, aligning with other plugins which use 1.3+ as their baseline.
  - [Cross-Cluster Replication PR opensearch-project#469](opensearch-project/cross-cluster-replication#469)
  - [Security PR #2253](opensearch-project/security#2253)
  - [ML Commons PR opensearch-project#681](opensearch-project/ml-commons#681)
- Post-upgrade, the twoThirdsUpgradedClusterTask runs successfully, suggesting potential incompatibility between versions 1.1 and 2.10.

Testing:
- Executed `./gradlew bwcTestSuite -Dtests.security.manager=false` and all tests passed.

Signed-off-by: Kaituo Li <kaituo@amazon.com>
jackiehanyang pushed a commit that referenced this pull request Sep 8, 2023
@kaituo
Upgrade AD's bwc baseline version to 1.3.2 to resolve cluster join is…
3c1a830 
…sue (#1029)

Issue:
- In versions between 1.1 and 2.10, the task :adBwcCluster#twoThirdsUpgradedClusterTask fails.
- Symptoms mirror those in [OpenSearch Issue #5076](opensearch-project/OpenSearch#5076).
- Logs show nodes from old and new versions failing to join as a cluster, resulting in a "master not found" exception.

Resolution:
- Upgraded the bwc version to 1.3.2, aligning with other plugins which use 1.3+ as their baseline.
  - [Cross-Cluster Replication PR #469](opensearch-project/cross-cluster-replication#469)
  - [Security PR #2253](opensearch-project/security#2253)
  - [ML Commons PR #681](opensearch-project/ml-commons#681)
- Post-upgrade, the twoThirdsUpgradedClusterTask runs successfully, suggesting potential incompatibility between versions 1.1 and 2.10.

Testing:
- Executed `./gradlew bwcTestSuite -Dtests.security.manager=false` and all tests passed.

Signed-off-by: Kaituo Li <kaituo@amazon.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 8, 2023
@kaituo @github-actions
Upgrade AD's bwc baseline version to 1.3.2 to resolve cluster join is…
8f44376 
…sue (#1029)

Issue:
- In versions between 1.1 and 2.10, the task :adBwcCluster#twoThirdsUpgradedClusterTask fails.
- Symptoms mirror those in [OpenSearch Issue #5076](opensearch-project/OpenSearch#5076).
- Logs show nodes from old and new versions failing to join as a cluster, resulting in a "master not found" exception.

Resolution:
- Upgraded the bwc version to 1.3.2, aligning with other plugins which use 1.3+ as their baseline.
  - [Cross-Cluster Replication PR #469](opensearch-project/cross-cluster-replication#469)
  - [Security PR #2253](opensearch-project/security#2253)
  - [ML Commons PR #681](opensearch-project/ml-commons#681)
- Post-upgrade, the twoThirdsUpgradedClusterTask runs successfully, suggesting potential incompatibility between versions 1.1 and 2.10.

Testing:
- Executed `./gradlew bwcTestSuite -Dtests.security.manager=false` and all tests passed.

Signed-off-by: Kaituo Li <kaituo@amazon.com>
(cherry picked from commit 3c1a830)
jackiehanyang pushed a commit that referenced this pull request Sep 8, 2023
@opensearch-trigger-bot @kaituo
Upgrade AD's bwc baseline version to 1.3.2 to resolve cluster join is…
7e20ba3 
…sue (#1029) (#1030)

Issue:
- In versions between 1.1 and 2.10, the task :adBwcCluster#twoThirdsUpgradedClusterTask fails.
- Symptoms mirror those in [OpenSearch Issue #5076](opensearch-project/OpenSearch#5076).
- Logs show nodes from old and new versions failing to join as a cluster, resulting in a "master not found" exception.

Resolution:
- Upgraded the bwc version to 1.3.2, aligning with other plugins which use 1.3+ as their baseline.
  - [Cross-Cluster Replication PR #469](opensearch-project/cross-cluster-replication#469)
  - [Security PR #2253](opensearch-project/security#2253)
  - [ML Commons PR #681](opensearch-project/ml-commons#681)
- Post-upgrade, the twoThirdsUpgradedClusterTask runs successfully, suggesting potential incompatibility between versions 1.1 and 2.10.

Testing:
- Executed `./gradlew bwcTestSuite -Dtests.security.manager=false` and all tests passed.

Signed-off-by: Kaituo Li <kaituo@amazon.com>
(cherry picked from commit 3c1a830)

Co-authored-by: Kaituo Li <kaituo@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zelinh zelinh zelinh approved these changes

@kaituo kaituo kaituo approved these changes

@Zhangxunmt Zhangxunmt Awaiting requested review from Zhangxunmt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amitgalitz @codecov-commenter @kaituo @zelinh