[Feature/extensions] Implements create components for AnomalyDetectionIndices and ADTaskManager #825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… components until SDKClusterSettings support is added Signed-off-by: Joshua Palis <jpalis@amazon.com>
…iggered from SDKRestClient Signed-off-by: Joshua Palis <jpalis@amazon.com>
owaiskazi19
requested changes
Feb 28, 2023
src/test/java/org/opensearch/ad/caching/PriorityCacheTests.java
Outdated
Show resolved
Hide resolved
src/test/java/org/opensearch/ad/task/ADTaskCacheManagerTests.java
Outdated
Show resolved
Hide resolved
dbwiddis
requested changes
Feb 28, 2023
src/test/java/org/opensearch/ad/caching/PriorityCacheTests.java
Outdated
Show resolved
Hide resolved
src/test/java/org/opensearch/ad/task/ADTaskCacheManagerTests.java
Outdated
Show resolved
Hide resolved
… test class, passed in SDKNamedXContentRegistry to ADTaskManagerreturning SDKRestClient as a created component to enable dependency injection, using multi-line comments s in PriorityCacheTests Signed-off-by: Joshua Palis <jpalis@amazon.com>
owaiskazi19
reviewed
Mar 1, 2023
Signed-off-by: Joshua Palis <jpalis@amazon.com>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## feature/extensions #825 +/- ##
========================================================
- Coverage 45.60% 39.89% -5.72%
+ Complexity 2458 2110 -348
========================================================
Files 297 297
Lines 17115 17094 -21
Branches 1843 1843
========================================================
- Hits 7805 6819 -986
- Misses 8740 9787 +1047
+ Partials 570 488 -82
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Joshua Palis <jpalis@amazon.com>
owaiskazi19
approved these changes
Mar 1, 2023
dbwiddis
requested changes
Mar 1, 2023
| private final Client client; | ||
| private final ClusterService clusterService; | ||
| private final NamedXContentRegistry xContentRegistry; | ||
| private final SDKRestClient sdkRestClient; |
There was a problem hiding this comment.
Can we keep the field name client here to minimize the diff with AD plugin?
| ClusterService clusterService, | ||
| Client client, | ||
| NamedXContentRegistry xContentRegistry, | ||
| Settings environmentSettings, |
There was a problem hiding this comment.
Can we keep the parameter name settings here to minimize the diff with AD plugin?
| @@ -1671,7 +1671,9 @@ protected <T> void deleteTaskDocs( | |||
| BulkRequest bulkRequest = new BulkRequest(); | |||
| while (iterator.hasNext()) { | |||
| SearchHit searchHit = iterator.next(); | |||
| try (XContentParser parser = createXContentParserFromRegistry(xContentRegistry, searchHit.getSourceRef())) { | |||
| try ( | |||
| XContentParser parser = createXContentParserFromRegistry(xContentRegistry.getRegistry(), searchHit.getSourceRef()) | |||
There was a problem hiding this comment.
Exactly as we want it. Someone (me? you?) should update the migration guide with this. Since it's part of create components should work nicely with this PR.
There was a problem hiding this comment.
Sure Ill take this as an action item
… client, settings. Spotless Apply Signed-off-by: Joshua Palis <jpalis@amazon.com>
|
With the recent upgrade to snakeyaml 2.0. SafeConstructor can be replaced with |
|
PR to fix the failure : opensearch-project/opensearch-sdk-java#504 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing create components, commented associated test classes for components until
SDKClusterSettingssupport is added.Issues Resolved
Part of : opensearch-project/opensearch-sdk-java#499
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.