Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix class loader issue for notifications response #40

Merged
merged 12 commits into from
Jul 20, 2021
Merged

Fix class loader issue for notifications response #40

merged 12 commits into from
Jul 20, 2021

Conversation

dai-chen
Copy link
Contributor

@dai-chen dai-chen commented Jul 19, 2021 •
edited
Loading

Description

Type cast error occurred when entering ActionResponse.onResponse(). The reason is due to different class loaders across plugins that explained in details here: opensearch-project/notifications#223. To solve the problem in similar way, wrap the listener by a new one with only difference on generic type (which is abstract ActionResponse rather than concrete XXXNotificationResponse to delay the casting operation after recreating response object by class loaded by current plugin class loader.

The main wrapper logic is patched from this #38. This PR is focused on adding missing UT to cover all notification APIs touched.

Issues Resolved

#37

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

joshuali925 and others added 8 commits July 15, 2021 15:19
@joshuali925 @dai-chen
Fix class loader issue for notifications
61e2d29 
Signed-off-by: Joshua Li <joshuali925@gmail.com>
@joshuali925 @dai-chen
Fix formatting
f1da692 
Signed-off-by: Joshua Li <joshuali925@gmail.com>
@joshuali925 @dai-chen
Refactor creation of action listener object
0e10617 
Signed-off-by: Joshua Li <joshuali925@gmail.com>
@joshuali925 @dai-chen
Fix indentation
2f12a31 
Signed-off-by: Joshua Li <joshuali925@gmail.com>
@joshuali925 @dai-chen
Remove unused suppresses
442e72d 
Signed-off-by: Joshua Li <joshuali925@gmail.com>
@dai-chen
Add UT for notification API
03142c7 
Signed-off-by: Chen Dai <daichen@amazon.com>
@dai-chen
Add UT for notification API
fa1feed 
Signed-off-by: Chen Dai <daichen@amazon.com>
@dai-chen
Add UT for send notification API
e668d9d 
Signed-off-by: Chen Dai <daichen@amazon.com>
@dai-chen dai-chen added the bug Something isn't working label Jul 19, 2021
@dai-chen dai-chen self-assigned this Jul 19, 2021
dai-chen added 3 commits July 19, 2021 11:55
@dai-chen
Fix Github workflow failure
1c57d40 
Signed-off-by: Chen Dai <daichen@amazon.com>
@dai-chen
Fix Github workflow failure
41ea8fd 
Signed-off-by: Chen Dai <daichen@amazon.com>
@dai-chen
Refactor UT code
bfe998a 
Signed-off-by: Chen Dai <daichen@amazon.com>
@dai-chen dai-chen marked this pull request as ready for review July 19, 2021 21:47
@dai-chen dai-chen requested review from joshuali925 and dblock July 19, 2021 21:47
@dai-chen dai-chen mentioned this pull request Jul 19, 2021
Closed
5 tasks
dblock
dblock approved these changes Jul 20, 2021
View reviewed changes
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@dai-chen dai-chen merged commit 4ef189d into opensearch-project:main Jul 20, 2021
@dai-chen dai-chen deleted the fix-classloader-issue branch July 20, 2021 16:37
adityaj1107 added a commit that referenced this pull request Jul 26, 2021
@adityaj1107 @zhongnansu
@dai-chen @joshuali925
Merge changes in the main branch to the 1.x branch. (#42)
45d053b 
* Update Release Notes for GA (#36)

* Update Release Notes for GA

* Update Release Notes for GA include RC1 Changes as well.

Signed-off-by: Aditya Jindal <aditjind@amazon.com>

* add method type in CustomWebhook data model (#39)

Signed-off-by: Zhongnan Su <szhongna@amazon.com>

* Fix class loader issue for notifications response (#40)

* Fix class loader issue for notifications

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* Fix formatting

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* Refactor creation of action listener object

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* Fix indentation

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* Remove unused suppresses

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* Add UT for notification API

Signed-off-by: Chen Dai <daichen@amazon.com>

* Add UT for notification API

Signed-off-by: Chen Dai <daichen@amazon.com>

* Add UT for send notification API

Signed-off-by: Chen Dai <daichen@amazon.com>

* Fix Github workflow failure

Signed-off-by: Chen Dai <daichen@amazon.com>

* Fix Github workflow failure

Signed-off-by: Chen Dai <daichen@amazon.com>

* Refactor UT code

Signed-off-by: Chen Dai <daichen@amazon.com>

Co-authored-by: Joshua Li <joshuali925@gmail.com>

Co-authored-by: Zhongnan Su <szhongna@amazon.com>
Co-authored-by: Chen Dai <46505291+dai-chen@users.noreply.github.com>
Co-authored-by: Joshua Li <joshuali925@gmail.com>
zelinh pushed a commit that referenced this pull request Aug 18, 2022
@dai-chen @joshuali925 @zelinh
Fix class loader issue for notifications response (#40)
87b8494 
* Fix class loader issue for notifications

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* Fix formatting

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* Refactor creation of action listener object

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* Fix indentation

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* Remove unused suppresses

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* Add UT for notification API

Signed-off-by: Chen Dai <daichen@amazon.com>

* Add UT for notification API

Signed-off-by: Chen Dai <daichen@amazon.com>

* Add UT for send notification API

Signed-off-by: Chen Dai <daichen@amazon.com>

* Fix Github workflow failure

Signed-off-by: Chen Dai <daichen@amazon.com>

* Fix Github workflow failure

Signed-off-by: Chen Dai <daichen@amazon.com>

* Refactor UT code

Signed-off-by: Chen Dai <daichen@amazon.com>

Co-authored-by: Joshua Li <joshuali925@gmail.com>
Signed-off-by: Zelin Hao <zelinhao@amazon.com>
wuychn pushed a commit to ochprince/common-utils that referenced this pull request Mar 16, 2023
@dai-chen @joshuali925
Fix class loader issue for notifications response (opensearch-project#40
9ca0d59 
)

* Fix class loader issue for notifications

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* Fix formatting

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* Refactor creation of action listener object

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* Fix indentation

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* Remove unused suppresses

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* Add UT for notification API

Signed-off-by: Chen Dai <daichen@amazon.com>

* Add UT for notification API

Signed-off-by: Chen Dai <daichen@amazon.com>

* Add UT for send notification API

Signed-off-by: Chen Dai <daichen@amazon.com>

* Fix Github workflow failure

Signed-off-by: Chen Dai <daichen@amazon.com>

* Fix Github workflow failure

Signed-off-by: Chen Dai <daichen@amazon.com>

* Refactor UT code

Signed-off-by: Chen Dai <daichen@amazon.com>

Co-authored-by: Joshua Li <joshuali925@gmail.com>
AWSHurneyt pushed a commit to AWSHurneyt/common-utils that referenced this pull request Feb 29, 2024
@adityaj1107 @zhongnansu
@dai-chen @joshuali925 @AWSHurneyt
Merge changes in the main branch to the 1.x branch. (opensearch-proje…
10ac92e 
…ct#42)

* Update Release Notes for GA (opensearch-project#36)

* Update Release Notes for GA

* Update Release Notes for GA include RC1 Changes as well.

Signed-off-by: Aditya Jindal <aditjind@amazon.com>

* add method type in CustomWebhook data model (opensearch-project#39)

Signed-off-by: Zhongnan Su <szhongna@amazon.com>

* Fix class loader issue for notifications response (opensearch-project#40)

* Fix class loader issue for notifications

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* Fix formatting

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* Refactor creation of action listener object

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* Fix indentation

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* Remove unused suppresses

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* Add UT for notification API

Signed-off-by: Chen Dai <daichen@amazon.com>

* Add UT for notification API

Signed-off-by: Chen Dai <daichen@amazon.com>

* Add UT for send notification API

Signed-off-by: Chen Dai <daichen@amazon.com>

* Fix Github workflow failure

Signed-off-by: Chen Dai <daichen@amazon.com>

* Fix Github workflow failure

Signed-off-by: Chen Dai <daichen@amazon.com>

* Refactor UT code

Signed-off-by: Chen Dai <daichen@amazon.com>

Co-authored-by: Joshua Li <joshuali925@gmail.com>

Co-authored-by: Zhongnan Su <szhongna@amazon.com>
Co-authored-by: Chen Dai <46505291+dai-chen@users.noreply.github.com>
Co-authored-by: Joshua Li <joshuali925@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
AWSHurneyt added a commit that referenced this pull request Feb 29, 2024
@AWSHurneyt @adityaj1107
@zhongnansu @dai-chen @joshuali925 @saratvemulapalli @skkosuri-amzn @VachaShah @dblock @bowenlan-amzn @thalurur @lezzago @downsrob @qreshi @mch2 @getsaurabh02 @ryanbogan @peternied @dbbaughe @mend-for-github-com @gaiksaya @opensearch-trigger-bot @opensearch-ci-bot @zelinh @prudhvigodithi @peterzhuamazon @sbcd90 @eirsep @cwperks
[Backport 1.3] Forced ktlint to use logback-core:1.2.13, and logback-…
a0baf55 
…classic:1.2.13 to address CVE. #602 (#603)

* Merge changes in the main branch to the 1.x branch. (#42)

* Update Release Notes for GA (#36)

* Update Release Notes for GA

* Update Release Notes for GA include RC1 Changes as well.

Signed-off-by: Aditya Jindal <aditjind@amazon.com>

* add method type in CustomWebhook data model (#39)

Signed-off-by: Zhongnan Su <szhongna@amazon.com>

* Fix class loader issue for notifications response (#40)

* Fix class loader issue for notifications

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* Fix formatting

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* Refactor creation of action listener object

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* Fix indentation

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* Remove unused suppresses

Signed-off-by: Joshua Li <joshuali925@gmail.com>

* Add UT for notification API

Signed-off-by: Chen Dai <daichen@amazon.com>

* Add UT for notification API

Signed-off-by: Chen Dai <daichen@amazon.com>

* Add UT for send notification API

Signed-off-by: Chen Dai <daichen@amazon.com>

* Fix Github workflow failure

Signed-off-by: Chen Dai <daichen@amazon.com>

* Fix Github workflow failure

Signed-off-by: Chen Dai <daichen@amazon.com>

* Refactor UT code

Signed-off-by: Chen Dai <daichen@amazon.com>

Co-authored-by: Joshua Li <joshuali925@gmail.com>

Co-authored-by: Zhongnan Su <szhongna@amazon.com>
Co-authored-by: Chen Dai <46505291+dai-chen@users.noreply.github.com>
Co-authored-by: Joshua Li <joshuali925@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* [1.x] Bumping common-utils to build with OpenSearch(1.x) 1.1.0 (#52)

* Bumping common-utils to build with OpenSearch(main) 1.1.0 (#48)

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>

* Updating 1.x to work with OpenSearch 1.x

Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Backport 1.1 changes to 1.x (#72)

* Add Commits related to Snapshot build of Common Utils on 1.1 (#67)

* Using 1.1 snapshot version for OpenSearch (#57)

Signed-off-by: Vacha <vachshah@amazon.com>

* Build snapshot build by default with the same version as OpenSearch. (#58)

Signed-off-by: dblock <dblock@amazon.com>

* Update build.gradle to reflect 1.1.0.0 version

Co-authored-by: Vacha <vachshah@amazon.com>
Co-authored-by: Daniel Doubrovkine (dB.) <dblock@dblock.org>

* Build snapshot build by default with the same version as OpenSearch. (#58) (#69)

Signed-off-by: dblock <dblock@amazon.com>

* Adding an utility method that allows consumers to set custom thread context property in InjectSecurity class (#47) (#70)

Signed-off-by: Ravi Thaluru <ravi1092@gmail.com>

Co-authored-by: Ravi <6005951+thalurur@users.noreply.github.com>

* Add release notes for version 1.1.0.0

* Add release notes for version 1.1.0.0

Co-authored-by: Aditya Jindal <13850971+aditjind@users.noreply.github.com>
Co-authored-by: Vacha <vachshah@amazon.com>
Co-authored-by: Daniel Doubrovkine (dB.) <dblock@dblock.org>
Co-authored-by: Bowen Lan <62091230+bowenlan-amzn@users.noreply.github.com>
Co-authored-by: Ravi <6005951+thalurur@users.noreply.github.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Backport main changes to 1.x (#93)

* Add themed logo to README (#41)

Signed-off-by: Miki <mehranb@amazon.com>

* Updates common-utils version to 1.2 (#77)

* Updates common-utils version to 1.2 and Uses Maven for 1.2 dependencies

Signed-off-by: Clay Downs <downsrob@amazon.com>

* Publish .md5 and .sha1 signatures. (#79) (#80)

* Publish .md5 and .sha1 signatures.

Signed-off-by: dblock <dblock@dblock.org>

* Use OpenSearch 1.1.

Signed-off-by: dblock <dblock@dblock.org>

* Publish source and javadoc checksums. (#81)

Signed-off-by: dblock <dblock@dblock.org>

* Update copyright notice (#90)

Signed-off-by: Mohammad Qureshi <qreshi@amazon.com>

* Update maven publication to include cksums. (#91)

This change adds a local staging repo task that will include cksums.  It will also update build.sh to use this new task and copy the contents of the staging repo to the output directory.
The maven publish plugin will not include these cksums when publishing to maven local but will when published to a separate folder.

Signed-off-by: Marc Handalian <handalm@amazon.com>

* Add release notes for version 1.2.0.0 (#92)

* Add release notes for version 1.2.0.0

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

Co-authored-by: Miki <mehranb@amazon.com>
Co-authored-by: Clay Downs <89109232+downsrob@users.noreply.github.com>
Co-authored-by: Daniel Doubrovkine (dB.) <dblock@dblock.org>
Co-authored-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com>
Co-authored-by: Marc Handalian <handalm@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Backport main changes to 1.x (#126)

* Fix copyright notice and add DCO check workflow (#94)

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

* Update build.sh script to include optional platform param. (#95)

Signed-off-by: Marc Handalian <handalm@amazon.com>

* Add codeowners support for repo (#96)

Signed-off-by: Ryan Bogan <10944539+ryanbogan@users.noreply.github.com>

* Bump version to 1.3 (#99)

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

* Auto-increment version on new release tags. (#106)

Signed-off-by: Daniel Doubrovkine (dB.) <dblock@dblock.org>

* Remove jcenter repository (#115)

Signed-off-by: Peter Nied <peternied@hotmail.com>

* Using Github App token to trigger CI for version increment PRs (#116)

Signed-off-by: Vacha Shah <vachshah@amazon.com>

* Fixes copyright headers (#117)

Signed-off-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>

* Remove jcenter repository missed on first pass (#118)

Signed-off-by: Peter Nied <petern@amazon.com>

* Run CI/CD on Java 8, 11, 14 and 17. (#121)

* Run CI/CD on Java 8, 11, 14 and 17.

Signed-off-by: Daniel Doubrovkine (dB.) <dblock@dblock.org>

* Add JDK 17.

Signed-off-by: Daniel Doubrovkine (dB.) <dblock@dblock.org>

* Add .whitesource configuration file (#109)

Co-authored-by: whitesource-for-github-com[bot] <50673670+whitesource-for-github-com[bot]@users.noreply.github.com>

Co-authored-by: Ashish Agrawal <ashisagr@amazon.com>
Co-authored-by: Marc Handalian <handalm@amazon.com>
Co-authored-by: Ryan Bogan <10944539+ryanbogan@users.noreply.github.com>
Co-authored-by: Daniel Doubrovkine (dB.) <dblock@dblock.org>
Co-authored-by: Peter Nied <peternied@hotmail.com>
Co-authored-by: Vacha Shah <vachshah@amazon.com>
Co-authored-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>
Co-authored-by: Peter Nied <petern@amazon.com>
Co-authored-by: whitesource-for-github-com[bot] <50673670+whitesource-for-github-com[bot]@users.noreply.github.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Add release notes for version 1.3.0.0 (#134)

Signed-off-by: Saurabh Singh <sisurab@amazon.com>

Co-authored-by: Saurabh Singh <sisurab@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Bump version to 1.3.1 (#145)

Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Incremented version to 1.3.2 (#148)

Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>

Co-authored-by: opensearch-ci-bot <opensearch-ci-bot@users.noreply.github.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Adding signoff option for version workflow PR (#143) (#150)

Signed-off-by: Vacha Shah <vachshah@amazon.com>
(cherry picked from commit 6e78f69)

Co-authored-by: Vacha Shah <vachshah@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Incremented version to 1.3.3. (#180)

Signed-off-by: dblock <dblock@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Incremented version to 1.3.4. (#198)

Signed-off-by: Zelin Hao <zelinhao@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Staging for version increment automation (#200) (#208)

* Version increment automation

Signed-off-by: pgodithi <pgodithi@amazon.com>

* Version increment automation: task rename updateVersion

Signed-off-by: pgodithi <pgodithi@amazon.com>
(cherry picked from commit 366bf16)
Signed-off-by: prudhvigodithi <pgodithi@amazon.com>

Signed-off-by: pgodithi <pgodithi@amazon.com>
Signed-off-by: prudhvigodithi <pgodithi@amazon.com>
Co-authored-by: Prudhvi Godithi <pgodithi@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* release 1.3.5 (#219)

Signed-off-by: prudhvigodithi <pgodithi@amazon.com>

Signed-off-by: prudhvigodithi <pgodithi@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Increment version to 1.3.6-SNAPSHOT (#243)

Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Change TrustStoreTest to use File.separator to support Windows path (#258) (#260)

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
(cherry picked from commit 7dcb3a0)

Co-authored-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* disable detekt so that snakeyaml <= 1.31 is not used (#266)

* disable detekt so that snakeyaml <= 1.31 is not used

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* add release-notes for 1.3.6 (#267)

Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* [AUTO] Increment version to 1.3.7-SNAPSHOT (#276)

* Increment version to 1.3.7-SNAPSHOT

Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com>

* empty commit trigger

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>

Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Co-authored-by: opensearch-ci-bot <opensearch-infra@amazon.com>
Co-authored-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Adding CI workflow for Windows OS (#333)

Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>

Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
Co-authored-by: Surya Sashank Nistala <sashank.nistala@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Increment version to 1.3.8-SNAPSHOT (#338)

Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com>

Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com>
Co-authored-by: opensearch-ci-bot <opensearch-infra@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Add auto-release workflow (#376) (#377)

Signed-off-by: Craig Perkins <cwperx@amazon.com>
(cherry picked from commit 89b7457)

Co-authored-by: Craig Perkins <craig5008@gmail.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Increment version to 1.3.9-SNAPSHOT (#355)

Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com>
Co-authored-by: opensearch-ci-bot <opensearch-infra@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Incremented version to 1.3.10 (#388)

Signed-off-by: GitHub <noreply@github.com>
Co-authored-by: opensearch-ci-bot <opensearch-ci-bot@users.noreply.github.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Increment version to 1.3.11-SNAPSHOT (#453)

Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com>
Co-authored-by: opensearch-ci-bot <opensearch-infra@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Increment version to 1.3.12-SNAPSHOT (#471)

Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com>
Co-authored-by: opensearch-ci-bot <opensearch-infra@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Increment version to 1.3.13-SNAPSHOT (#504)

Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com>
Co-authored-by: opensearch-ci-bot <opensearch-infra@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Increment version to 1.3.14-SNAPSHOT (#540)

Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com>
Co-authored-by: opensearch-ci-bot <opensearch-infra@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* [AUTO] Increment version to 1.3.15-SNAPSHOT (#575)

* Increment version to 1.3.15-SNAPSHOT

Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com>

* Empty-Commit

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

* Remove jdk 8 CI test

Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>

---------

Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com>
Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
Co-authored-by: opensearch-ci-bot <opensearch-infra@amazon.com>
Co-authored-by: Ashish Agrawal <ashisagr@amazon.com>
Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

* Forced ktlint to use logback-core:1.2.13, and logback-classic:1.2.13 to address CVE. (#602)

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>

---------

Signed-off-by: AWSHurneyt <hurneyt@amazon.com>
Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
Signed-off-by: dblock <dblock@amazon.com>
Signed-off-by: Zelin Hao <zelinhao@amazon.com>
Signed-off-by: pgodithi <pgodithi@amazon.com>
Signed-off-by: prudhvigodithi <pgodithi@amazon.com>
Signed-off-by: opensearch-ci-bot <opensearch-infra@amazon.com>
Signed-off-by: Subhobrata Dey <sbcd90@gmail.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
Co-authored-by: Aditya Jindal <13850971+aditjind@users.noreply.github.com>
Co-authored-by: Zhongnan Su <szhongna@amazon.com>
Co-authored-by: Chen Dai <46505291+dai-chen@users.noreply.github.com>
Co-authored-by: Joshua Li <joshuali925@gmail.com>
Co-authored-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>
Co-authored-by: Sriram <59816283+skkosuri-amzn@users.noreply.github.com>
Co-authored-by: Vacha <vachshah@amazon.com>
Co-authored-by: Daniel Doubrovkine (dB.) <dblock@dblock.org>
Co-authored-by: Bowen Lan <62091230+bowenlan-amzn@users.noreply.github.com>
Co-authored-by: Ravi <6005951+thalurur@users.noreply.github.com>
Co-authored-by: Ashish Agrawal <ashisagr@amazon.com>
Co-authored-by: Miki <mehranb@amazon.com>
Co-authored-by: Clay Downs <89109232+downsrob@users.noreply.github.com>
Co-authored-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com>
Co-authored-by: Marc Handalian <handalm@amazon.com>
Co-authored-by: Saurabh Singh <getsaurabh02@gmail.com>
Co-authored-by: Ryan Bogan <10944539+ryanbogan@users.noreply.github.com>
Co-authored-by: Peter Nied <peternied@hotmail.com>
Co-authored-by: Drew Baugher <46505179+dbbaughe@users.noreply.github.com>
Co-authored-by: Peter Nied <petern@amazon.com>
Co-authored-by: whitesource-for-github-com[bot] <50673670+whitesource-for-github-com[bot]@users.noreply.github.com>
Co-authored-by: Saurabh Singh <sisurab@amazon.com>
Co-authored-by: Sayali Gaikawad <61760125+gaiksaya@users.noreply.github.com>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Co-authored-by: opensearch-ci-bot <opensearch-ci-bot@users.noreply.github.com>
Co-authored-by: Daniel (dB.) Doubrovkine <dblock@amazon.com>
Co-authored-by: Zelin Hao <87548827+zelinh@users.noreply.github.com>
Co-authored-by: Prudhvi Godithi <pgodithi@amazon.com>
Co-authored-by: Peter Zhu <zhujiaxi@amazon.com>
Co-authored-by: Subhobrata Dey <sbcd90@gmail.com>
Co-authored-by: opensearch-ci-bot <opensearch-infra@amazon.com>
Co-authored-by: Surya Sashank Nistala <sashank.nistala@gmail.com>
Co-authored-by: Craig Perkins <craig5008@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuali925 joshuali925 joshuali925 approved these changes

@dblock dblock dblock approved these changes

Assignees

@dai-chen dai-chen

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dai-chen @dblock @joshuali925