Skip to content

Conversation

@gaiksaya
Copy link
Member

@gaiksaya gaiksaya commented Aug 5, 2025

Description

Report code coverage to codecov

Related Issues

#261

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
@reta
Copy link
Collaborator

reta commented Aug 5, 2025

Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
@gaiksaya
Copy link
Member Author

gaiksaya commented Aug 5, 2025

Needs opensearch-project/OpenSearch#18933

Let me know if we can run

./gradlew wrapper --gradle-version 8.14.3 --distribution-type all --gradle-distribution-sha256-sum ed1a8d686605fd7c23bdf62c7fc7add1c5b23b2bbc3721e661934ef4a4911d7c

@reta
Copy link
Collaborator

reta commented Aug 5, 2025

Let me know if we can run

We could do that as well, sure, the opensearch-project/OpenSearch#18933 would have to be merged anyway

Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
@reta reta merged commit 3a5ab27 into opensearch-project:main Aug 5, 2025
12 checks passed
@gaiksaya
Copy link
Member Author

gaiksaya commented Aug 5, 2025

@reta Looks like codecov did not run. Can you please check? Looks like something related to https://github.com/opensearch-project/custom-codecs/blob/main/.github/workflows/check.yml#L37 ?

@gaiksaya gaiksaya deleted the fix-java branch August 5, 2025 23:54
@gaiksaya
Copy link
Member Author

gaiksaya commented Aug 6, 2025

@reta
Another error:
https://github.com/opensearch-project/custom-codecs/actions/runs/16765236163/job/47468930541?pr=268

[2025-08-06T01:33:32.114Z] ['info'] Warning: Some files located via search were excluded from upload.
[2025-08-06T01:33:32.114Z] ['info'] If Codecov did not locate your files, please review https://docs.codecov.com/docs/supported-report-formats
[2025-08-06T01:33:32.114Z] ['error'] There was an error running the uploader: No coverage files located, please try use `-f`, or change the project root with `-R`
[2025-08-06T01:33:32.114Z] ['info'] Codecov will exit with status code 0. If you are expecting a non-zero exit code, please pass in the `-Z` flag

Looks like it was not able to find the files for coverage.
It can be added using files args. I tried finding in local but was not able to

@reta
Copy link
Collaborator

reta commented Aug 6, 2025

It can be added using files args. I tried finding in local but was not able to

Thanks @gaiksaya , I will take a look tomorrow during the day

@reta reta mentioned this pull request Aug 6, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants