Create prometheus datasource flow #1054

derek-ho · 2023-09-27T15:44:49Z

Description

Adds create prometheus datasource from UI flow
Uses Application navigateToApp in order to navigate between different plugins
Shows different linking cards in the data connections page based on the datasource type

Issues Resolved

[List any issues this PR will resolve]

Check List

New functionality includes testing.
- All tests pass, including unit test, integration test and doctest
New functionality has been documented.
- New functionality has javadoc added
- New functionality has user manual doc added
Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

* fix name change bug and modify test to test behavior Signed-off-by: Derek Ho <dxho@amazon.com> * get rid of lint Signed-off-by: Derek Ho <dxho@amazon.com> * test for flyout Signed-off-by: Derek Ho <dxho@amazon.com> * flyout to medium size Signed-off-by: Derek Ho <dxho@amazon.com> * make accelerate extensible Signed-off-by: Derek Ho <dxho@amazon.com> * get datasources and hook up to pplservice Signed-off-by: Derek Ho <dxho@amazon.com> * get flint working Signed-off-by: Derek Ho <dxho@amazon.com> * add datasource page with steps and buttons on bottom bar Signed-off-by: Derek Ho <dxho@amazon.com> * datasources as a new plugin and mostly working Signed-off-by: Derek Ho <dxho@amazon.com> * hook up manage to show datasources call Signed-off-by: Derek Ho <dxho@amazon.com> * update two tables with descriptions Signed-off-by: Derek Ho <dxho@amazon.com> * make some updates to the page Signed-off-by: Derek Ho <dxho@amazon.com> * cleanup unused files for data connections Signed-off-by: Derek Ho <dxho@amazon.com> * cleanup and add overview panel columns Signed-off-by: Derek Ho <dxho@amazon.com> * render tabs Signed-off-by: Derek Ho <dxho@amazon.com> * add unit tests Signed-off-by: Derek Ho <dxho@amazon.com> * update data test subj and snapshot Signed-off-by: Derek Ho <dxho@amazon.com> * Add datasources to management overview Signed-off-by: Derek Ho <dxho@amazon.com> * remove spark logo and update snapshot Signed-off-by: Derek Ho <dxho@amazon.com> * refactor routes out Signed-off-by: Derek Ho <dxho@amazon.com> * separate out the roles Signed-off-by: Derek Ho <dxho@amazon.com> * bump version back to 3.0 Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com>

* add acceleration management UI skeleton Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * Create new documentation link for acc Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * fix typos and minor bugs Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update snapshot Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update window location to hash Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * remove unused headers Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* rename data sources to data connections Signed-off-by: Derek Ho <dxho@amazon.com> * final cleanup Signed-off-by: Derek Ho <dxho@amazon.com> * update acceleration breadcrumb Signed-off-by: Derek Ho <dxho@amazon.com> * fix API call for data connection page Signed-off-by: Derek Ho <dxho@amazon.com> * fix integ test and data test subj and snapshot Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com>

…opensearch-project#1008) * add fallback ui for manage and view datasources Signed-off-by: Derek Ho <dxho@amazon.com> * always show datasources via pplservice Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com>

* basic rendering for the access control tab Signed-off-by: Derek Ho <dxho@amazon.com> * hook up basic radio groups and euicombo boxes for query and acceleration permissions Signed-off-by: Derek Ho <dxho@amazon.com> * refactor and clean up unuseed inports Signed-off-by: Derek Ho <dxho@amazon.com> * remove unused import Signed-off-by: Derek Ho <dxho@amazon.com> * fix import and snapshot Signed-off-by: Derek Ho <dxho@amazon.com> * fix test Signed-off-by: Derek Ho <dxho@amazon.com> * Address PR comments Signed-off-by: Derek Ho <dxho@amazon.com> * Address PR comments Signed-off-by: Derek Ho <dxho@amazon.com> * Remove unused files and variables Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com>

…t#1024) * Address previous PR comments and implement rudimentary delete Signed-off-by: Derek Ho <dxho@amazon.com> * Implement modal and instant delete showing up in list Signed-off-by: Derek Ho <dxho@amazon.com> * Refactor save or cancel to a shared component, implement hard coded datasource configurations tab Signed-off-by: Derek Ho <dxho@amazon.com> * Update test with mock role data Signed-off-by: Derek Ho <dxho@amazon.com> * Add most functionality of edit connectiondetails Signed-off-by: Derek Ho <dxho@amazon.com> * Address PR comments Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com>

Signed-off-by: Derek Ho <dxho@amazon.com>

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

… tests Signed-off-by: Derek Ho <dxho@amazon.com>

…boards-observability into configure Signed-off-by: Derek Ho <dxho@amazon.com>

Signed-off-by: Derek Ho <dxho@amazon.com>

…vability into configure Signed-off-by: Derek Ho <dxho@amazon.com>

Signed-off-by: Derek Ho <dxho@amazon.com>

…vability into prometheus Signed-off-by: Derek Ho <dxho@amazon.com>

derek-ho · 2023-09-27T15:50:37Z

public/components/datasources/components/new/review_s3_datasource_configuration.tsx

@@ -13,6 +13,7 @@ import {
 EuiFlexItem,
 EuiButton,
 } from '@elastic/eui';
+import { Role } from 'common/types/data_connections';


Missed this in the previous PR

codecov · 2023-09-27T16:11:23Z

Codecov Report

Merging #1054 (d8283b1) into main (79d18df) will increase coverage by 0.00%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             main    #1054    +/-   ##
========================================
  Coverage   44.43%   44.44%            
========================================
  Files         325      325            
  Lines       19071    19096    +25     
  Branches     4633     4580    -53     
========================================
+ Hits         8475     8488    +13     
- Misses      10052    10565   +513     
+ Partials      544       43   -501

Flag	Coverage Δ
dashboards-observability	`44.44% <ø> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 84 files with indirect coverage changes

Signed-off-by: Derek Ho <dxho@amazon.com>

opensearch_dashboards.json

Signed-off-by: Derek Ho <dxho@amazon.com>

public/framework/core_refs.ts

public/components/datasources/components/manage/connection_configuration.tsx

public/components/datasources/components/manage/data_connection.tsx

ps48 · 2023-09-28T16:32:05Z

public/components/datasources/components/new/configure_datasource.tsx

+ currentName={name}
+ currentDetails={details}
+ setNameForRequest={setName}
+ setDetailsForRequest={setDetails}
+ currentStore={storeURI}
+ setStoreForRequest={setStoreURI}
+ roles={roles}
+ currentUsername={username}
+ setUsernameForRequest={setUsername}
+ currentPassword={password}
+ setPasswordForRequest={setPassword}
+ selectedQueryPermissionRoles={selectedQueryPermissionRoles}
+ setSelectedQueryPermissionRoles={setSelectedQueryPermissionRoles}
+ currentAccessKey={accessKey}
+ currentSecretKey={secretKey}
+ setAccessKeyForRequest={setAccessKey}
+ setSecretKeyForRequest={setSecretKey}
+ currentRegion={region}
+ setRegionForRequest={setRegion}


Question: Is there a way to reduce the number of props here?

This is side effect of this issue: #1054 (comment), if there is a cleaner way to do it I am all for it, but I couldn't find one with quick search

This wouldn't be an issue if we render the form inline, but rendering the form as a child is causing issues

Maybe mis-understood your question here - I don't think there is a way to do so, since I need to know the values in the parent in order to send the request and have a way of updating them in the child. Thus I need to pass in value and setter for each of the possible configuration properties. Consolidating it into an object might be cleaner, but I think this way makes it clear what is going in and as what. Leaning towards keeping it like this for now

ps48

Added minor comments

Signed-off-by: Derek Ho <dxho@amazon.com>

Swiddis · 2023-09-29T16:28:40Z

public/components/datasources/components/new/configure_datasource.tsx

+ currentDetails={details}
+ currentArn={arn}
+ currentStore={storeURI}
+ currentUsername={username}


Mentioned in other comment, but this would benefit from being consolidated in a currentContext object or something of the sort

Swiddis · 2023-09-29T16:29:07Z

public/components/datasources/components/new/configure_datasource.tsx

+ 'glue.auth.role_arn': arn,
+ 'glue.indexstore.opensearch.uri': storeURI,
+ 'glue.indexstore.opensearch.auth': false,
+ 'glue.indexstore.opensearch.region': 'us-west-2',


Should this be hardcoded?

* Manage datasources (opensearch-project#967) * fix name change bug and modify test to test behavior Signed-off-by: Derek Ho <dxho@amazon.com> * get rid of lint Signed-off-by: Derek Ho <dxho@amazon.com> * test for flyout Signed-off-by: Derek Ho <dxho@amazon.com> * flyout to medium size Signed-off-by: Derek Ho <dxho@amazon.com> * make accelerate extensible Signed-off-by: Derek Ho <dxho@amazon.com> * get datasources and hook up to pplservice Signed-off-by: Derek Ho <dxho@amazon.com> * get flint working Signed-off-by: Derek Ho <dxho@amazon.com> * add datasource page with steps and buttons on bottom bar Signed-off-by: Derek Ho <dxho@amazon.com> * datasources as a new plugin and mostly working Signed-off-by: Derek Ho <dxho@amazon.com> * hook up manage to show datasources call Signed-off-by: Derek Ho <dxho@amazon.com> * update two tables with descriptions Signed-off-by: Derek Ho <dxho@amazon.com> * make some updates to the page Signed-off-by: Derek Ho <dxho@amazon.com> * cleanup unused files for data connections Signed-off-by: Derek Ho <dxho@amazon.com> * cleanup and add overview panel columns Signed-off-by: Derek Ho <dxho@amazon.com> * render tabs Signed-off-by: Derek Ho <dxho@amazon.com> * add unit tests Signed-off-by: Derek Ho <dxho@amazon.com> * update data test subj and snapshot Signed-off-by: Derek Ho <dxho@amazon.com> * Add datasources to management overview Signed-off-by: Derek Ho <dxho@amazon.com> * remove spark logo and update snapshot Signed-off-by: Derek Ho <dxho@amazon.com> * refactor routes out Signed-off-by: Derek Ho <dxho@amazon.com> * separate out the roles Signed-off-by: Derek Ho <dxho@amazon.com> * bump version back to 3.0 Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> * Add acceleration management UI (opensearch-project#989) * add acceleration management UI skeleton Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * Create new documentation link for acc Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * fix typos and minor bugs Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update snapshot Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update window location to hash Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * remove unused headers Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * Rename data sources to data connections (opensearch-project#1004) * rename data sources to data connections Signed-off-by: Derek Ho <dxho@amazon.com> * final cleanup Signed-off-by: Derek Ho <dxho@amazon.com> * update acceleration breadcrumb Signed-off-by: Derek Ho <dxho@amazon.com> * fix API call for data connection page Signed-off-by: Derek Ho <dxho@amazon.com> * fix integ test and data test subj and snapshot Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> * Add fallback to show if user does not have datasource API permissions (opensearch-project#1008) * add fallback ui for manage and view datasources Signed-off-by: Derek Ho <dxho@amazon.com> * always show datasources via pplservice Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> * Add access control tab content (opensearch-project#992) * basic rendering for the access control tab Signed-off-by: Derek Ho <dxho@amazon.com> * hook up basic radio groups and euicombo boxes for query and acceleration permissions Signed-off-by: Derek Ho <dxho@amazon.com> * refactor and clean up unuseed inports Signed-off-by: Derek Ho <dxho@amazon.com> * remove unused import Signed-off-by: Derek Ho <dxho@amazon.com> * fix import and snapshot Signed-off-by: Derek Ho <dxho@amazon.com> * fix test Signed-off-by: Derek Ho <dxho@amazon.com> * Address PR comments Signed-off-by: Derek Ho <dxho@amazon.com> * Address PR comments Signed-off-by: Derek Ho <dxho@amazon.com> * Remove unused files and variables Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> * Delete datasource and Connection Configuration Tab (opensearch-project#1024) * Address previous PR comments and implement rudimentary delete Signed-off-by: Derek Ho <dxho@amazon.com> * Implement modal and instant delete showing up in list Signed-off-by: Derek Ho <dxho@amazon.com> * Refactor save or cancel to a shared component, implement hard coded datasource configurations tab Signed-off-by: Derek Ho <dxho@amazon.com> * Update test with mock role data Signed-off-by: Derek Ho <dxho@amazon.com> * Add most functionality of edit connectiondetails Signed-off-by: Derek Ho <dxho@amazon.com> * Address PR comments Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> * Get most of the workflow working for configure datasource Signed-off-by: Derek Ho <dxho@amazon.com> * remove acceleration components Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * Update data connection to datasources in a few more places and update tests Signed-off-by: Derek Ho <dxho@amazon.com> * Rename and re-organize in folders Signed-off-by: Derek Ho <dxho@amazon.com> * Fix import path in testing file Signed-off-by: Derek Ho <dxho@amazon.com> * Get Initial S3 configuration working Signed-off-by: Derek Ho <dxho@amazon.com> * Configure S3 Data Source Working Signed-off-by: Derek Ho <dxho@amazon.com> * Fix query permissions display Signed-off-by: Derek Ho <dxho@amazon.com> * Fix merge conflict Signed-off-by: Derek Ho <dxho@amazon.com> * Clean up PR Signed-off-by: Derek Ho <dxho@amazon.com> * Add s3 logo in manage table Signed-off-by: Derek Ho <dxho@amazon.com> * Fix up PR according to UX feedback Signed-off-by: Derek Ho <dxho@amazon.com> * Remove successfully Signed-off-by: Derek Ho <dxho@amazon.com> * Update test Signed-off-by: Derek Ho <dxho@amazon.com> * Initial commit adding prometheus logo and icon Signed-off-by: Derek Ho <dxho@amazon.com> * Get the major flow working Signed-off-by: Derek Ho <dxho@amazon.com> * Fix app navigation Signed-off-by: Derek Ho <dxho@amazon.com> * Fix up PR Signed-off-by: Derek Ho <dxho@amazon.com> * Remove management redirection for now and fix test and add cards Signed-off-by: Derek Ho <dxho@amazon.com> * Remove type filter and update test according to UX feedback Signed-off-by: Derek Ho <dxho@amazon.com> * Add link and update test Signed-off-by: Derek Ho <dxho@amazon.com> * Address PR comments Signed-off-by: Derek Ho <dxho@amazon.com> * Include useful info in the error toast Signed-off-by: Derek Ho <dxho@amazon.com> * Update actions in manage table according to UX feedback Signed-off-by: Derek Ho <dxho@amazon.com> * Add update button and update tests Signed-off-by: Derek Ho <dxho@amazon.com> * Remove unused code until further implementation Signed-off-by: Derek Ho <dxho@amazon.com> * Fix router files Signed-off-by: Derek Ho <dxho@amazon.com> --------- Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Co-authored-by: Shenoy Pratik <sgguruda@amazon.com>

* Update mocha (#960) * added code for the change of design of the sidebar, fixed overriding … (#928) * Refactor add_integration_flyout to break out nested methods (#956) * [Log Explorer] Remove top level tabs (#970) * Explorer's timeheader & color change (#959) * Update caching (#965) * Move query_utils to /public (#983) * Remove Zeppelin Parser from Notebook (#985) * Explorer empty bucket (#990) * refactored classnames for sidebar (#933) * Refactor Integrations Backend to abstract IO (#947) * Create React component for Integrations Setup UI (#1009) * Create Data sources plugin with Manage Datasources Flow (#1035) * Manage datasources (#967) * Add acceleration management UI (#989) * Rename data sources to data connections (#1004) * Add fallback to show if user does not have datasource API permissions (#1008) * Add access control tab content (#992) * Delete datasource and Connection Configuration Tab (#1024) * adjust explorer chart color and spacing (#1051) * Configure S3 datasource flow (#1049) * Manage datasources (#967) * Add acceleration management UI (#989) * Rename data sources to data connections (#1004) * Add fallback to show if user does not have datasource API permissions (#1008) * Add access control tab content (#992) * Delete datasource and Connection Configuration Tab (#1024) * modified explorer data grid to follow discover look and feel (#1041) * Create prometheus datasource flow (#1054) * Manage datasources (#967) * Add acceleration management UI (#989) * Rename data sources to data connections (#1004) * Add fallback to show if user does not have datasource API permissions (#1008) * Add access control tab content (#992) * Delete datasource and Connection Configuration Tab (#1024) * added design changes for sidebar (#1061) * updated snapshots (#1062) * Update UI for integrations setup (#1052) * Data sources UI improvements (#1059) * adding redirection to datasources (#1063) * Move convertDateTime, refactor query_utils (#1064) * Setup S3 connection with integrations (#1057) * Use approved svg from UX (#1066) * Fix missing import 'moment' on query_utils. (#1067) --------- Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: sumukhswamy <sumukhhs@amazon.com> Signed-off-by: Eric Wei <menwe@amazon.com> Signed-off-by: Paul Sebastian <paulstn@amazon.com> Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com> Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Signed-off-by: Simeon Widdis <sawiddis@gmail.com> Co-authored-by: sumukhswamy <sumukhhs@amazon.com> Co-authored-by: Eric Wei <menwe@amazon.com> Co-authored-by: Paul Sebastian <paul_sebastian@live.com> Co-authored-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com> Co-authored-by: Paul Sebastian <paulstn@amazon.com> Co-authored-by: Shenoy Pratik <sgguruda@amazon.com> Co-authored-by: Simeon Widdis <sawiddis@amazon.com>

* Update mocha (opensearch-project#960) * added code for the change of design of the sidebar, fixed overriding … (opensearch-project#928) * Refactor add_integration_flyout to break out nested methods (opensearch-project#956) * [Log Explorer] Remove top level tabs (opensearch-project#970) * Explorer's timeheader & color change (opensearch-project#959) * Update caching (opensearch-project#965) * Move query_utils to /public (opensearch-project#983) * Remove Zeppelin Parser from Notebook (opensearch-project#985) * Explorer empty bucket (opensearch-project#990) * refactored classnames for sidebar (opensearch-project#933) * Refactor Integrations Backend to abstract IO (opensearch-project#947) * Create React component for Integrations Setup UI (opensearch-project#1009) * Create Data sources plugin with Manage Datasources Flow (opensearch-project#1035) * Manage datasources (opensearch-project#967) * Add acceleration management UI (opensearch-project#989) * Rename data sources to data connections (opensearch-project#1004) * Add fallback to show if user does not have datasource API permissions (opensearch-project#1008) * Add access control tab content (opensearch-project#992) * Delete datasource and Connection Configuration Tab (opensearch-project#1024) * adjust explorer chart color and spacing (opensearch-project#1051) * Configure S3 datasource flow (opensearch-project#1049) * Manage datasources (opensearch-project#967) * Add acceleration management UI (opensearch-project#989) * Rename data sources to data connections (opensearch-project#1004) * Add fallback to show if user does not have datasource API permissions (opensearch-project#1008) * Add access control tab content (opensearch-project#992) * Delete datasource and Connection Configuration Tab (opensearch-project#1024) * modified explorer data grid to follow discover look and feel (opensearch-project#1041) * Create prometheus datasource flow (opensearch-project#1054) * Manage datasources (opensearch-project#967) * Add acceleration management UI (opensearch-project#989) * Rename data sources to data connections (opensearch-project#1004) * Add fallback to show if user does not have datasource API permissions (opensearch-project#1008) * Add access control tab content (opensearch-project#992) * Delete datasource and Connection Configuration Tab (opensearch-project#1024) * added design changes for sidebar (opensearch-project#1061) * updated snapshots (opensearch-project#1062) * Update UI for integrations setup (opensearch-project#1052) * Data sources UI improvements (opensearch-project#1059) * adding redirection to datasources (opensearch-project#1063) * Move convertDateTime, refactor query_utils (opensearch-project#1064) * Setup S3 connection with integrations (opensearch-project#1057) * Use approved svg from UX (opensearch-project#1066) * Fix missing import 'moment' on query_utils. (opensearch-project#1067) --------- Signed-off-by: Derek Ho <dxho@amazon.com> Signed-off-by: sumukhswamy <sumukhhs@amazon.com> Signed-off-by: Eric Wei <menwe@amazon.com> Signed-off-by: Paul Sebastian <paulstn@amazon.com> Signed-off-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com> Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Signed-off-by: Simeon Widdis <sawiddis@gmail.com> Co-authored-by: sumukhswamy <sumukhhs@amazon.com> Co-authored-by: Eric Wei <menwe@amazon.com> Co-authored-by: Paul Sebastian <paul_sebastian@live.com> Co-authored-by: Peter Fitzgibbons <peter.fitzgibbons@gmail.com> Co-authored-by: Paul Sebastian <paulstn@amazon.com> Co-authored-by: Shenoy Pratik <sgguruda@amazon.com> Co-authored-by: Simeon Widdis <sawiddis@amazon.com> (cherry picked from commit 171acde)

derek-ho and others added 24 commits September 7, 2023 10:36

Get most of the workflow working for configure datasource

1efd191

Signed-off-by: Derek Ho <dxho@amazon.com>

remove acceleration components

ad153ed

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

Update data connection to datasources in a few more places and update…

93ad0dd

… tests Signed-off-by: Derek Ho <dxho@amazon.com>

Merge branch 'feature/flint-UI' of github.com:opensearch-project/dash…

d98cd8d

…boards-observability into configure Signed-off-by: Derek Ho <dxho@amazon.com>

Rename and re-organize in folders

2bd8c27

Signed-off-by: Derek Ho <dxho@amazon.com>

Fix import path in testing file

cc7b1a2

Signed-off-by: Derek Ho <dxho@amazon.com>

Get Initial S3 configuration working

ed8cfc1

Signed-off-by: Derek Ho <dxho@amazon.com>

Configure S3 Data Source Working

0b84fab

Signed-off-by: Derek Ho <dxho@amazon.com>

Fix query permissions display

6d8a98f

Signed-off-by: Derek Ho <dxho@amazon.com>

Merge branch 'main' of github.com:opensearch-project/dashboards-obser…

e8b831f

…vability into configure Signed-off-by: Derek Ho <dxho@amazon.com>

Fix merge conflict

7a3f085

Signed-off-by: Derek Ho <dxho@amazon.com>

Clean up PR

1ffdfb0

Signed-off-by: Derek Ho <dxho@amazon.com>

Add s3 logo in manage table

7a333bf

Signed-off-by: Derek Ho <dxho@amazon.com>

Fix up PR according to UX feedback

c5f1eae

Signed-off-by: Derek Ho <dxho@amazon.com>

Remove successfully

23699bc

Signed-off-by: Derek Ho <dxho@amazon.com>

Update test

51bb5d4

Signed-off-by: Derek Ho <dxho@amazon.com>

Initial commit adding prometheus logo and icon

6726750

Signed-off-by: Derek Ho <dxho@amazon.com>

Merge branch 'main' of github.com:opensearch-project/dashboards-obser…

b47c1e9

…vability into prometheus Signed-off-by: Derek Ho <dxho@amazon.com>

derek-ho commented Sep 27, 2023

View reviewed changes

derek-ho added 3 commits September 27, 2023 14:43

Get the major flow working

a9a9dda

Signed-off-by: Derek Ho <dxho@amazon.com>

Fix app navigation

bc5cadc

Signed-off-by: Derek Ho <dxho@amazon.com>

Fix up PR

cf9c45b

Signed-off-by: Derek Ho <dxho@amazon.com>

derek-ho commented Sep 28, 2023

View reviewed changes

opensearch_dashboards.json Outdated Show resolved Hide resolved

derek-ho requested review from joshuali925, dai-chen, YANG-DB, rupal-bq, mengweieric, vamsi-amazon, Swiddis, penghuo, seankao-az and anirudha as code owners September 28, 2023 14:57

Remove type filter and update test according to UX feedback

655fa07

Signed-off-by: Derek Ho <dxho@amazon.com>

ps48 reviewed Sep 28, 2023

View reviewed changes

public/framework/core_refs.ts Outdated Show resolved Hide resolved

ps48 reviewed Sep 28, 2023

View reviewed changes

public/components/datasources/components/manage/connection_configuration.tsx Outdated Show resolved Hide resolved

ps48 reviewed Sep 28, 2023

View reviewed changes

public/components/datasources/components/manage/data_connection.tsx Outdated Show resolved Hide resolved

ps48 reviewed Sep 28, 2023

View reviewed changes

ps48 approved these changes Sep 28, 2023

View reviewed changes

derek-ho added 7 commits September 28, 2023 14:38

Add link and update test

cca73f8

Signed-off-by: Derek Ho <dxho@amazon.com>

Address PR comments

6d3894b

Signed-off-by: Derek Ho <dxho@amazon.com>

Include useful info in the error toast

09b3db4

Signed-off-by: Derek Ho <dxho@amazon.com>

Update actions in manage table according to UX feedback

2a329e2

Signed-off-by: Derek Ho <dxho@amazon.com>

Add update button and update tests

8cbe04d

Signed-off-by: Derek Ho <dxho@amazon.com>

Remove unused code until further implementation

3ddb81d

Signed-off-by: Derek Ho <dxho@amazon.com>

Fix router files

d8283b1

Signed-off-by: Derek Ho <dxho@amazon.com>

Swiddis reviewed Sep 29, 2023

View reviewed changes

Swiddis approved these changes Sep 29, 2023

View reviewed changes

derek-ho merged commit 6ef3f4b into opensearch-project:main Sep 29, 2023
9 checks passed

derek-ho deleted the prometheus branch September 29, 2023 17:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create prometheus datasource flow #1054

Create prometheus datasource flow #1054

derek-ho commented Sep 27, 2023 •

edited

Loading

derek-ho Sep 27, 2023

codecov bot commented Sep 27, 2023 •

edited

Loading

ps48 Sep 28, 2023

derek-ho Sep 28, 2023

derek-ho Sep 28, 2023

derek-ho Sep 28, 2023

ps48 left a comment

Swiddis Sep 29, 2023

Swiddis Sep 29, 2023

Create prometheus datasource flow #1054

Create prometheus datasource flow #1054

Conversation

derek-ho commented Sep 27, 2023 • edited Loading

Description

Issues Resolved

Check List

derek-ho Sep 27, 2023

Choose a reason for hiding this comment

codecov bot commented Sep 27, 2023 • edited Loading

Codecov Report

ps48 Sep 28, 2023

Choose a reason for hiding this comment

derek-ho Sep 28, 2023

Choose a reason for hiding this comment

derek-ho Sep 28, 2023

Choose a reason for hiding this comment

derek-ho Sep 28, 2023

Choose a reason for hiding this comment

ps48 left a comment

Choose a reason for hiding this comment

Swiddis Sep 29, 2023

Choose a reason for hiding this comment

Swiddis Sep 29, 2023

Choose a reason for hiding this comment

derek-ho commented Sep 27, 2023 •

edited

Loading

codecov bot commented Sep 27, 2023 •

edited

Loading