Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create prometheus datasource flow #1054
Create prometheus datasource flow #1054
Changes from 27 commits
73becc4
6e42a2b
24cdd19
dfd5bd8
28201e9
89eafa2
1efd191
ad153ed
93ad0dd
d98cd8d
2bd8c27
cc7b1a2
ed8cfc1
0b84fab
6d8a98f
e8b831f
7a3f085
1ffdfb0
7a333bf
c5f1eae
23699bc
51bb5d4
6726750
b47c1e9
a9a9dda
bc5cadc
cf9c45b
8fb8220
655fa07
cca73f8
6d3894b
09b3db4
2a329e2
8cbe04d
3ddb81d
d8283b1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: Is there a way to reduce the number of props here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is side effect of this issue: #1054 (comment), if there is a cleaner way to do it I am all for it, but I couldn't find one with quick search
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This wouldn't be an issue if we render the form inline, but rendering the form as a child is causing issues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe mis-understood your question here - I don't think there is a way to do so, since I need to know the values in the parent in order to send the request and have a way of updating them in the child. Thus I need to pass in value and setter for each of the possible configuration properties. Consolidating it into an object might be cleaner, but I think this way makes it clear what is going in and as what. Leaning towards keeping it like this for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mentioned in other comment, but this would benefit from being consolidated in a
currentContext
object or something of the sortThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be hardcoded?