Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Disable integration set up button if invalid #1160

Merged
merged 1 commit into from
Oct 24, 2023
Merged

[Backport 2.x] Disable integration set up button if invalid #1160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions ...omponents/integrations/components/__tests__/__snapshots__/setup_integration.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -735,7 +735,8 @@ exports[`Integration Setup Page Renders integration setup page as expected 1`] =
class="euiFlexItem euiFlexItem--flexGrowZero"
>
<button
class="euiButton euiButton--primary euiButton--fill"
class="euiButton euiButton--primary euiButton--fill euiButton-isDisabled"
disabled=""
type="button"
>
<span
Expand Down Expand Up @@ -889,6 +890,7 @@ exports[`Integration Setup Page Renders integration setup page as expected 1`] =
className="euiFlexItem euiFlexItem--flexGrowZero"
>
<EuiButton
disabled={true}
fill={true}
iconSide="right"
iconType="arrowRight"
Expand All @@ -897,19 +899,19 @@ exports[`Integration Setup Page Renders integration setup page as expected 1`] =
>
<EuiButtonDisplay
baseClassName="euiButton"
disabled={false}
disabled={true}
element="button"
fill={true}
iconSide="right"
iconType="arrowRight"
isDisabled={false}
isDisabled={true}
isLoading={false}
onClick={[Function]}
type="button"
>
<button
className="euiButton euiButton--primary euiButton--fill"
disabled={false}
className="euiButton euiButton--primary euiButton--fill euiButton-isDisabled"
disabled={true}
onClick={[Function]}
style={
Object {
Expand Down
2 changes: 1 addition & 1 deletion public/components/integrations/components/setup_integration.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ import {
EuiForm,
EuiFormRow,
EuiLoadingDashboards,
EuiModal,
EuiPage,
EuiPageBody,
EuiPageContent,
Expand Down Expand Up @@ -296,6 +295,7 @@ export function SetupBottomBar({
iconType="arrowRight"
iconSide="right"
isLoading={loading}
disabled={config.displayName.length < 1 || config.connectionDataSource.length < 1}
onClick={async () => {
setLoading(true);

Expand Down
Loading