Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix otel_logs_source server configuration for getHttpAuthenticationService #5212

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

dlvenable
Copy link
Member

@dlvenable dlvenable commented Nov 21, 2024

Description

Data Prepper plugins can implement authentication for gRPC sources using GrpcAuthenticationProvider::getHttpAuthenticationService instead of GrpcAuthenticationProvider::getAuthenticationInterceptor.

The otel_logs_source is not supporting that alternative approach.

This fixes the behavior, but it does not affect the current authentication mechanisms provided since they use getAuthenticationInterceptor.

Issues Resolved

N/A

Check List

  • New functionality includes testing.
  • New functionality has a documentation issue. Please link to it in this PR.
    • New functionality has javadoc added
  • Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…o also support the getHttpAuthenticationService() alternative approach.

Signed-off-by: David Venable <dlv@amazon.com>
@dlvenable dlvenable merged commit 6c9cdeb into opensearch-project:main Nov 21, 2024
47 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.10 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.10 2.10
# Navigate to the new working tree
cd .worktrees/backport-2.10
# Create a new branch
git switch --create backport/backport-5212-to-2.10
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6c9cdebcdb5c26901d68659ec8ae017693681900
# Push it to GitHub
git push --set-upstream origin backport/backport-5212-to-2.10
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.10

Then, create a pull request where the base branch is 2.10 and the compare/head branch is backport/backport-5212-to-2.10.

dlvenable added a commit to dlvenable/data-prepper that referenced this pull request Nov 25, 2024
…o also support the getHttpAuthenticationService() alternative approach. (opensearch-project#5212)

Signed-off-by: David Venable <dlv@amazon.com>
(cherry picked from commit 6c9cdeb)
dlvenable added a commit that referenced this pull request Nov 26, 2024
…o also support the getHttpAuthenticationService() alternative approach. (#5212) (#5215)

Signed-off-by: David Venable <dlv@amazon.com>
(cherry picked from commit 6c9cdeb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants