feat: Add serviceMonitor resource

[shubham-cmyk]

Description

It would add a prometheus serviceMonitor resource.

Check List

• Commits are signed per the DCO using --signoff

For any changes to files within Helm chart directories:

• Helm chart version bumped
• Helm chart CHANGELOG.md updated to reflect change

PR sponsored by Obmondo.com

[smbambling]

Is this inteded to be used in conjunction with https://github.com/Aiven-Open/prometheus-exporter-plugin-for-opensearch/tree/main ?

If so might I suggest setting the path to "/_prometheus/metrics"

[TheAlgo]

Thanks for raising the PR. Can you look at lint failures once? Also is there an Github issue for this feature? It will be great if we can have one.

[shubham-cmyk]

@TheAlgo
Bumped the chart version can you run the check again

[eyenx]

We would love to have this feature in the chart!

[gaiksaya]

Hi @shubham-cmyk
Can you please rebase? Looks like branch has a conflict.

[eyenx]

@shubham-cmyk do you need any help with this? we are looking forward to have this feature in the chart.

[peterzhuamazon]

I will take a look tomorrow and see if I can help rebase.

Thanks.

[peterzhuamazon]

I updated the version and changelog and tried to push but not able to do so, seems like the repo belongs to an org:

$ git push origin serviceMonitor
ERROR: Permission to Obmondo/helm-charts-1.git denied to peterzhuamazon.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

Hi @shubham-cmyk could you please update the PR?

Thanks.

[VILJkid]

Hi team,

I'll be picking up where @shubham-cmyk left off to address the recent changes. I'll update the PR shortly with the necessary adjustments. Thanks for your patience, and I’ll keep you posted on the progress!

[eyenx]

Thanks @VILJkid

[VILJkid]

@eyenx, I’ve taken care of the rebase and chart version bump. @shubham-cmyk is on vacation, so please review the changes and inform me if any additional updates are needed.

[eyenx]

@TheAlgo can we merge this?

[VILJkid]

The requested changes have been pushed. Kindly review and merge this feature.

Thanks for your time,
@prudhvigodithi @eyenx @bbarani @DandyDeveloper @peterzhuamazon @gaiksaya @TheAlgo

[TheAlgo]

Can you check lint failures before reviewers can take a look?

[VILJkid]

Thanks @TheAlgo!

The lint failures, and changelog version comparison is fixed!

[VILJkid]

Thanks @peterzhuamazon!

The fix has been pushed and the minor versions have been bumped up, as per the change request.

[peterzhuamazon]

Hi @shubham-cmyk @VILJkid ,

I am fine with this PR now.
Giving my approval.
Waiting for @prudhvigodithi @TheAlgo to do another pass before merging.
Once this is merged if you could help create another backport to 1.x branch, that would be great to have.

Thanks for contribution.

[prudhvigodithi]

Thanks @shubham-cmyk @VILJkid @peterzhuamazon @TheAlgo , LGTM we can merge once the CI checks pass.

Since we have 2 approvals and addressed @TheAlgo initial comment, will merge now. Thanks.

[peterzhuamazon]

Thanks @shubham-cmyk @VILJkid ,

Would you be able to backport this change to 1.x branch?

Thanks!

[VILJkid]

Thanks @peterzhuamazon,

Yes, I'll raise another PR with this change for branch 1.x shortly.

[VILJkid]

Hi @peterzhuamazon,

Here's the PR for backporting this change to 1.x : #578