Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing xcontent imports #353

Merged
merged 2 commits into from
Mar 28, 2023
Merged

Fixing xcontent imports #353

merged 2 commits into from
Mar 28, 2023

Conversation

joshpalis
Copy link
Member

Description

Fixes xcontent imports now that base classes have been moved to core

Issues Resolved

#350

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Joshua Palis <jpalis@amazon.com>
@joshpalis
Copy link
Member Author

joshpalis commented Mar 28, 2023

This PR is failing due to stale OpenSearch snapshots used for BWC tests, will kick off another 2.7.0 build

Signed-off-by: Joshua Palis <jpalis@amazon.com>
@codecov-commenter
Copy link

Codecov Report

Merging #353 (b9fd175) into 2.x (5081933) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff            @@
##                2.x     #353   +/-   ##
=========================================
  Coverage     52.33%   52.33%           
  Complexity       65       65           
=========================================
  Files             8        8           
  Lines           449      449           
  Branches         50       50           
=========================================
  Hits            235      235           
  Misses          195      195           
  Partials         19       19           
Impacted Files Coverage Δ
...rg/opensearch/jobscheduler/JobSchedulerPlugin.java 36.53% <ø> (ø)
...rg/opensearch/jobscheduler/sweeper/JobSweeper.java 39.49% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@joshpalis joshpalis merged commit 5f11ac5 into opensearch-project:2.x Mar 28, 2023
@joshpalis joshpalis deleted the fix2.x branch March 28, 2023 23:43
prudhvigodithi pushed a commit to prudhvigodithi/job-scheduler that referenced this pull request May 9, 2023
* Fixing xcontent imports

Signed-off-by: Joshua Palis <jpalis@amazon.com>

* Updating parsefield import

Signed-off-by: Joshua Palis <jpalis@amazon.com>

---------

Signed-off-by: Joshua Palis <jpalis@amazon.com>
Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants