[Backport 1.x] [BUG FIX] Add space type default and ef search parameter in warmup #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
) Sets the default value of space type to L2 in KNNIndexShard. KNNIndexShard is used during warmup to load segments into memory. For indices created in ES 7.1 and 7.4, they will not have this value set because the only space we supported was l2. So, we need to hardcode the defaults here. For nmslib, the ef_search parameter is configurable at load time. So, it needs to be passed as a parameter in both the search load phase as well as warmup. This commit adds it to the warmup phase and abstracts load parameters to a helper function so that it can be consistent for both search and warmup. Signed-off-by: John Mazanec <jmazane@amazon.com> (cherry picked from commit 2fb2ad1)
Codecov Report
@@ Coverage Diff @@
## 1.x #279 +/- ##
=========================================
Coverage 83.38% 83.38%
- Complexity 884 885 +1
=========================================
Files 127 127
Lines 3833 3834 +1
Branches 361 361
=========================================
+ Hits 3196 3197 +1
Misses 475 475
Partials 162 162
Continue to review full report at Codecov.
|
martin-gaievski
approved these changes
Feb 10, 2022
jmazanec15
approved these changes
Feb 10, 2022
martin-gaievski
pushed a commit
to martin-gaievski/k-NN
that referenced
this pull request
Mar 7, 2022
…pensearch-project#279) Sets the default value of space type to L2 in KNNIndexShard. KNNIndexShard is used during warmup to load segments into memory. For indices created in ES 7.1 and 7.4, they will not have this value set because the only space we supported was l2. So, we need to hardcode the defaults here. For nmslib, the ef_search parameter is configurable at load time. So, it needs to be passed as a parameter in both the search load phase as well as warmup. This commit adds it to the warmup phase and abstracts load parameters to a helper function so that it can be consistent for both search and warmup. Signed-off-by: John Mazanec <jmazane@amazon.com> (cherry picked from commit 2fb2ad1)
martin-gaievski
pushed a commit
to martin-gaievski/k-NN
that referenced
this pull request
Mar 7, 2022
…pensearch-project#279) Sets the default value of space type to L2 in KNNIndexShard. KNNIndexShard is used during warmup to load segments into memory. For indices created in ES 7.1 and 7.4, they will not have this value set because the only space we supported was l2. So, we need to hardcode the defaults here. For nmslib, the ef_search parameter is configurable at load time. So, it needs to be passed as a parameter in both the search load phase as well as warmup. This commit adds it to the warmup phase and abstracts load parameters to a helper function so that it can be consistent for both search and warmup. Signed-off-by: John Mazanec <jmazane@amazon.com> (cherry picked from commit 2fb2ad1) Signed-off-by: Martin Gaievski <gaievski@amazon.com>
martin-gaievski
pushed a commit
to martin-gaievski/k-NN
that referenced
this pull request
Mar 31, 2022
…pensearch-project#279) Sets the default value of space type to L2 in KNNIndexShard. KNNIndexShard is used during warmup to load segments into memory. For indices created in ES 7.1 and 7.4, they will not have this value set because the only space we supported was l2. So, we need to hardcode the defaults here. For nmslib, the ef_search parameter is configurable at load time. So, it needs to be passed as a parameter in both the search load phase as well as warmup. This commit adds it to the warmup phase and abstracts load parameters to a helper function so that it can be consistent for both search and warmup. Signed-off-by: John Mazanec <jmazane@amazon.com> (cherry picked from commit 2fb2ad1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 2fb2ad1 from #276