Add github action for secure integ tests #836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-gaievski
added
Infrastructure
martin-gaievski
force-pushed
the
add-secure-integ-test-github-action
branch
3 times, most recently
from
9d8f699 to
da4a7ae
Compare
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #836 +/- ##
============================================
- Coverage 85.17% 85.10% -0.07%
Complexity 1086 1086
============================================
Files 152 152
Lines 4404 4404
Branches 393 393
============================================
- Hits 3751 3748 -3
- Misses 474 477 +3
Partials 179 179 see 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
martin-gaievski
force-pushed
the
add-secure-integ-test-github-action
branch
24 times, most recently
from
3e6dda3 to
193aa9b
Compare
martin-gaievski
force-pushed
the
add-secure-integ-test-github-action
branch
6 times, most recently
from
65eaee7 to
a6deb50
Compare
martin-gaievski
changed the title
Signed-off-by: Martin Gaievski <gaievski@amazon.com>
martin-gaievski
force-pushed
the
add-secure-integ-test-github-action
branch
from
a6deb50 to
8c6ac66
Compare
navneet1v
reviewed
Apr 7, 2023
.github/workflows/test_security.yml
Outdated
| @@ -0,0 +1,96 @@ | |||
| name: Security test workflow for k-NN | |||
There was a problem hiding this comment.
Rename this to, test k-NN on Secure Cluster
.github/workflows/test_security.yml
Outdated
| matrix: | ||
| java: [ 11,17 ] | ||
| os: [ubuntu-latest] | ||
| fail-fast: false |
There was a problem hiding this comment.
why this is false? I think we should make it true.
.github/workflows/test_security.yml
Outdated
| os: [ubuntu-latest] | ||
| fail-fast: false | ||
|
|
||
| name: Security test workflow for k-NN Plugin |
There was a problem hiding this comment.
update the name as suggested above.
Signed-off-by: Martin Gaievski <gaievski@amazon.com>
navneet1v
previously approved these changes
Apr 11, 2023
jmazanec15
previously approved these changes
Apr 11, 2023
martin-gaievski
dismissed stale reviews from jmazanec15 and navneet1v
via
3f4ae65
jmazanec15
approved these changes
Apr 12, 2023
naveentatikonda
approved these changes
Apr 12, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 12, 2023
Signed-off-by: Martin Gaievski <gaievski@amazon.com> (cherry picked from commit 303d811)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 12, 2023
Signed-off-by: Martin Gaievski <gaievski@amazon.com> (cherry picked from commit 303d811)
naveentatikonda
pushed a commit
that referenced
this pull request
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding github action to run integ tests against cluster with security plugin. Approach is mainly taken from AD plugin https://github.com/opensearch-project/anomaly-detection/blob/main/.github/workflows/test_security.yml. Currently we're not able to build artifacts for native libraries in our regular assemble task, so for this iteration will be using latest pre-built versions from docker image. This means they may be different from PR version in case we're changing those libs in scope of PR. We'll be running tests on linux as this gives sufficient confidence, and for macos/win the docker setup has some difficulties.
PR requires #827 and #847 to be merged
Issues Resolved
opensearch-project/security#2265
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.