-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build against aws-sdk-core. #267
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also update release-notes/logstash-output-opensearch-release-notes-next.md please?
(I think we should move release notes into a CHANGELOG like other projects in this org and add a workflow that checks that the file is updated in every PR, but that's beyond the scope of this.)
logstash-output-opensearch.gemspec
Outdated
@@ -11,7 +11,7 @@ signing_key_path = "gem-private_key.pem" | |||
|
|||
Gem::Specification.new do |s| | |||
s.name = 'logstash-output-opensearch' | |||
s.version = '2.0.3' | |||
s.version = '2.0.4.pre' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make this 2.1.0 since we're changing dependencies.
9414c40
to
9be76ab
Compare
|
||
Compatible with OpenSearch 1.3+, 2.0+ | ||
|
||
### Bug Fixes | ||
|
||
* Fix warning retrieving cluster UUID with Amazon OpenSearch Serverless (#237) | ||
* Install against most recent versions of logstash by building with [aws-sdk-core](https://rubygems.org/gems/aws-sdk-core). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Include the PR number in your new line as well.
Signed-off-by: Paulo E. Castro <paulo.castro@hmrc.gov.uk>
9be76ab
to
5426e45
Compare
Thanks, check the failing test above @pecastro? Thanks for hanging in here with me. |
Description
Builds opensearch plugin that can be deployed against the more recent versions of logstash.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.
Solves this: