Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address build failures #741

Merged
merged 3 commits into from
Feb 23, 2023
Merged

Conversation

MaxKsyunz
Copy link
Contributor

Description

Xcontent classes were moved in this PR opensearch-project/OpenSearch#5902 causing builds to fail.

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
@MaxKsyunz MaxKsyunz requested a review from a team February 22, 2023 08:12
@MaxKsyunz
Copy link
Contributor Author

common-utils needs to be updated first before this PR can build.
See opensearch-project/common-utils#367

acarbonetto
acarbonetto previously approved these changes Feb 22, 2023
@acarbonetto
Copy link

common-utils needs to be updated first before this PR can build. See opensearch-project/common-utils#367

This has been merged

MaxKsyunz added 2 commits February 22, 2023 21:19
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
Signed-off-by: MaxKsyunz <maxk@bitquilltech.com>
@MaxKsyunz
Copy link
Contributor Author

MaxKsyunz commented Feb 23, 2023

@ylwu-amzn could you kick-off github actions again please?

They were run before updated snapshot of common-utils was available. I also needed to run ./gradlew spotless on my branch. build and test passes now.

@codecov-commenter
Copy link

Codecov Report

Merging #741 (eebabe2) into main (a08e482) will increase coverage by 0.11%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main     #741      +/-   ##
============================================
+ Coverage     84.55%   84.66%   +0.11%     
- Complexity      986      988       +2     
============================================
  Files            92       92              
  Lines          3542     3542              
  Branches        326      326              
============================================
+ Hits           2995     2999       +4     
+ Misses          410      407       -3     
+ Partials        137      136       -1     
Flag Coverage Δ
ml-commons 84.66% <ø> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../opensearch/ml/action/handler/MLSearchHandler.java 86.66% <ø> (ø)
...earch/ml/action/load/TransportLoadModelAction.java 89.32% <ø> (ø)
...ml/action/load/TransportLoadModelOnNodeAction.java 94.44% <ø> (ø)
...arch/ml/action/models/GetModelTransportAction.java 78.78% <ø> (ø)
...earch/ml/action/profile/MLProfileNodeResponse.java 89.18% <ø> (ø)
...pensearch/ml/action/profile/MLProfileResponse.java 94.73% <ø> (ø)
...pensearch/ml/action/stats/MLStatsNodeResponse.java 95.65% <ø> (ø)
...ensearch/ml/action/stats/MLStatsNodesResponse.java 94.73% <ø> (ø)
.../ml/action/syncup/TransportSyncUpOnNodeAction.java 93.93% <ø> (ø)
...search/ml/action/tasks/GetTaskTransportAction.java 78.12% <ø> (ø)
... and 26 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants