Added spec for k-NN stats api #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saimedhi
requested review from
dblock,
harshavamsi,
pgtgrly,
sachetalva,
nhtruong,
Xtansia and
VachaShah
as code owners
saimedhi
force-pushed
the
add/knn
branch
3 times, most recently
from
8214683 to
05a58cc
Compare
saimedhi
commented
Feb 22, 2024
nhtruong
reviewed
Feb 22, 2024
| @mixin | ||
| structure KNNStats_QueryParams { | ||
| @httpQuery("timeout") | ||
| timeout: Timeout, |
There was a problem hiding this comment.
I see pretty querystring param in the examples as well.
There was a problem hiding this comment.
Theo, pretty is a global parameter.
Those parameters can be used with all APIs. So, we won't write them in spec. Please confirm?
Signed-off-by: saimedhi <saimedhi@amazon.com>
Signed-off-by: saimedhi <saimedhi@amazon.com>
Xtansia
previously approved these changes
Feb 27, 2024
Signed-off-by: Sai Medhini Reddy Maryada <117196660+saimedhi@users.noreply.github.com>
dblock
approved these changes
Mar 7, 2024
Xtansia
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
Related to #168,
opensearch-project/opensearch-py#300
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.