Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed POST and DELETE /_dangling/{index_uuid} returning 202 #686

Merged
merged 7 commits into from
Nov 21, 2024

Conversation

dblock
Copy link
Member

@dblock dblock commented Nov 20, 2024

Description

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Nov 20, 2024

Changes Analysis

Commit SHA: f6b8a43
Comparing To SHA: 7e4e18e

API Changes

Summary

├─┬Paths
│ └─┬/_dangling/{index_uuid}
│   ├─┬POST
│   │ └─┬Responses
│   │   ├──[➕] codes (28419:7)
│   │   └──[➖] codes (28419:7)❌ 
│   └─┬DELETE
│     └─┬Responses
│       ├──[➕] codes (28413:7)
│       └──[➖] codes (28413:7)❌ 
└─┬Components
  ├──[➖] responses (28413:7)❌ 
  ├──[➖] responses (28419:7)❌ 
  ├──[➕] responses (28419:7)
  └──[➕] responses (28413:7)

Document Element Total Changes Breaking Changes
paths 4 2
components 4 2
  • BREAKING Changes: 4 out of 8
  • Removals: 4
  • Additions: 4
  • Breaking Removals: 4

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/11956880138/artifacts/2219662824

API Coverage

Before After Δ
Covered (%) 599 (58.67 %) 599 (58.67 %) 0 (0 %)
Uncovered (%) 422 (41.33 %) 422 (41.33 %) 0 (0 %)
Unknown 42 42 0

Copy link
Contributor

github-actions bot commented Nov 20, 2024

Spec Test Coverage Analysis

Total Tested
528 372 (70.45 %)

@dblock dblock force-pushed the dangling-index-tests branch 2 times, most recently from b3c9037 to f7f8a48 Compare November 21, 2024 14:03
@dblock dblock changed the title WIP: Dangling index tests. Fixed POST and DELETE /_dangling/{index_uuid} returning 202 Nov 21, 2024
Signed-off-by: dblock <dblock@amazon.com>
Signed-off-by: dblock <dblock@amazon.com>
Signed-off-by: dblock <dblock@amazon.com>
Signed-off-by: dblock <dblock@amazon.com>
@dblock dblock force-pushed the dangling-index-tests branch from 41d225f to 7cec698 Compare November 21, 2024 15:12
Signed-off-by: dblock <dblock@amazon.com>
Signed-off-by: dblock <dblock@amazon.com>
@dblock dblock marked this pull request as ready for review November 21, 2024 15:35
Signed-off-by: dblock <dblock@amazon.com>
@dblock dblock merged commit 22bdd5c into opensearch-project:main Nov 21, 2024
29 checks passed
@dblock dblock deleted the dangling-index-tests branch November 21, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants