Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed content-type of GET /_plugins/_observability/_local/stats. #711

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

dblock
Copy link
Member

@dblock dblock commented Dec 9, 2024

Description

  • Fixed content-type of GET /_plugins/_observability/_local/stats.
  • Removed tenant from ObservabilityObject being required.
  • Added missing observability tests.

Issues Resolved

Part of #663.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dblock dblock force-pushed the observability-tests branch from fc43391 to 5285aa1 Compare December 9, 2024 13:49
@dblock dblock changed the title Added missing observability tests. Fixed content-type of GET /_plugins/_observability/_local/stats, added tests. Dec 9, 2024
Copy link
Contributor

github-actions bot commented Dec 9, 2024

Changes Analysis

Commit SHA: 9e8fd5a
Comparing To SHA: 415bad4

API Changes

Summary

├─┬Paths
│ └─┬/_plugins/_observability/_local/stats
│   └─┬GET
│     ├──[🔀] description (5069:20)
│     ├─┬Responses
│     │ └─┬200
│     │   ├──[➕] content (30374:11)
│     │   └──[➖] content (30374:11)❌ 
│     └─┬Extensions
│       └──[🔀] x-version-added (5068:24)
└─┬Components
  └─┬observability._common___ObservabilityObject
    └──[➖] required (56129:11)❌ 

Document Element Total Changes Breaking Changes
paths 4 1
components 1 1
  • BREAKING Changes: 2 out of 5
  • Modifications: 2
  • Removals: 2
  • Additions: 1
  • Breaking Removals: 2

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/12248168208/artifacts/2297435634

API Coverage

Before After Δ
Covered (%) 606 (59.35 %) 606 (59.35 %) 0 (0 %)
Uncovered (%) 415 (40.65 %) 415 (40.65 %) 0 (0 %)
Unknown 43 43 0

@dblock dblock force-pushed the observability-tests branch 3 times, most recently from d371828 to 3debf75 Compare December 9, 2024 17:48
@dblock dblock changed the title Fixed content-type of GET /_plugins/_observability/_local/stats, added tests. Fixed content-type of GET /_plugins/_observability/_local/stats, added support for retry in prologues/epilogues, added tests. Dec 9, 2024
@dblock dblock changed the title Fixed content-type of GET /_plugins/_observability/_local/stats, added support for retry in prologues/epilogues, added tests. Fixed content-type of GET /_plugins/_observability/_local/stats. Dec 9, 2024
@dblock dblock force-pushed the observability-tests branch 4 times, most recently from 69a002d to 32b4c5c Compare December 9, 2024 18:41
Copy link
Contributor

github-actions bot commented Dec 9, 2024

Spec Test Coverage Analysis

Total Tested
536 439 (81.9 %)

Added missing observability object tests.

Signed-off-by: dblock <dblock@amazon.com>
@dblock dblock force-pushed the observability-tests branch from 32b4c5c to e461092 Compare December 9, 2024 18:43
Signed-off-by: Thomas Farr <tsfarr@amazon.com>
@Xtansia Xtansia merged commit be446ac into opensearch-project:main Dec 10, 2024
26 of 27 checks passed
@dblock dblock deleted the observability-tests branch December 10, 2024 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants