Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix snapshot status numeric property types #729

Merged
merged 4 commits into from
Dec 12, 2024

Conversation

Xtansia
Copy link
Collaborator

@Xtansia Xtansia commented Dec 12, 2024

Description

Fix snapshot status numeric property types

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Thomas Farr <tsfarr@amazon.com>
Signed-off-by: Thomas Farr <tsfarr@amazon.com>
Copy link
Contributor

github-actions bot commented Dec 12, 2024

Changes Analysis

Commit SHA: 36336a8
Comparing To SHA: 25c1c67

API Changes

Summary

└─┬Components
  ├─┬snapshot._common___Status
  │ └──[➖] required (58831:11)❌ 
  ├─┬snapshot._common___ShardsStats
  │ ├─┬failed
  │ │ ├──[🔀] type (58639:17)❌ 
  │ │ └──[➕] format (58640:19)❌ 
  │ ├─┬total
  │ │ ├──[🔀] type (58651:17)❌ 
  │ │ └──[➕] format (58652:19)❌ 
  │ ├─┬started
  │ │ ├──[🔀] type (58648:17)❌ 
  │ │ └──[➕] format (58649:19)❌ 
  │ ├─┬initializing
  │ │ ├──[🔀] type (58645:17)❌ 
  │ │ └──[➕] format (58646:19)❌ 
  │ ├─┬finalizing
  │ │ ├──[🔀] type (58642:17)❌ 
  │ │ └──[➕] format (58643:19)❌ 
  │ └─┬done
  │   ├──[🔀] type (58636:17)❌ 
  │   └──[➕] format (58637:19)❌ 
  ├─┬snapshot._common___FileCountSnapshotStats
  │ └─┬file_count
  │   ├──[🔀] type (58598:17)❌ 
  │   └──[➕] format (58599:19)❌ 
  ├─┬snapshot._common___ShardsStatsStage
  │ ├──[➖] enum (58665:11)❌ 
  │ ├──[➖] enum (58666:11)❌ 
  │ ├──[➖] enum (58662:11)❌ 
  │ ├──[➖] enum (58663:11)❌ 
  │ ├──[➖] enum (58664:11)❌ 
  │ ├──[➖] type (58660:13)❌ 
  │ ├──[➕] oneOf (58674:11)
  │ ├──[➕] oneOf (58668:11)
  │ ├──[➕] oneOf (58662:11)
  │ ├──[➕] oneOf (58671:11)
  │ └──[➕] oneOf (58665:11)
  ├─┬snapshot._common___ShardsStatsSummaryItem
  │ └─┬file_count
  │   ├──[🔀] type (58701:17)❌ 
  │   └──[➕] format (58702:19)❌ 
  ├─┬snapshot._common___SnapshotStats
  │ └──[➕] properties (58813:9)
  ├─┬snapshot._common___SnapshotShardsStatus
  │ ├──[➕] properties (58797:9)
  │ └──[➕] properties (58799:9)
  ├─┬snapshot._common___ShardsStatsSummary
  │ └──[➕] properties (58682:9)
  └─┬snapshot._common___RepositorySettings
    ├─┬read_only
    │ └──[🔀] $ref (34142:20)❌ 
    ├─┬compress
    │ └──[🔀] $ref (34142:20)❌ 
    └─┬concurrent_streams
      └──[🔀] $ref (34177:20)❌ 

Document Element Total Changes Breaking Changes
components 35 26
  • BREAKING Changes: 26 out of 35
  • Modifications: 11
  • Removals: 7
  • Additions: 17
  • Breaking Removals: 7
  • Breaking Modifications: 11
  • Breaking Additions: 8

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/12289741481/artifacts/2309691508

API Coverage

Before After Δ
Covered (%) 606 (59.35 %) 606 (59.35 %) 0 (0 %)
Uncovered (%) 415 (40.65 %) 415 (40.65 %) 0 (0 %)
Unknown 43 43 0

Copy link
Contributor

github-actions bot commented Dec 12, 2024

Spec Test Coverage Analysis

Total Tested
536 478 (89.18 %)

Signed-off-by: Thomas Farr <tsfarr@amazon.com>
Signed-off-by: Thomas Farr <tsfarr@amazon.com>
@dblock dblock merged commit e955278 into opensearch-project:main Dec 12, 2024
28 checks passed
@dblock dblock mentioned this pull request Dec 12, 2024
@Xtansia Xtansia deleted the fix/snapshot-schemas branch December 12, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants