Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for using a certificate and key, fixed /_plugins/_security/api/nodesdn. #731

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dblock
Copy link
Member

@dblock dblock commented Dec 13, 2024

Description

  • Added support for using a certificate and key.
  • Fixed request schema for PATCH /_plugins/_security/api/nodesdn
  • Fixed response schema for GET /_plugins/_security/api/nodesdn/{cluster_name}

Issues Resolved

Part of #663.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Dec 13, 2024

Changes Analysis

Commit SHA: ee96bdb
Comparing To SHA: ebe0f8a

API Changes

Summary

├─┬Paths
│ ├─┬/_opendistro/_security/api/nodesdn/{cluster_name}
│ │ ├─┬GET
│ │ │ └─┬Responses
│ │ │   └─┬200
│ │ │     └─┬application/json
│ │ │       └─┬Schema
│ │ │         └──[🔀] $ref (57817:13)❌ 
│ │ ├─┬PUT
│ │ │ └─┬Responses
│ │ │   └──[➕] codes (31644:7)
│ │ └─┬PATCH
│ │   └─┬Requestbody
│ │     └─┬application/json
│ │       └─┬Schema
│ │         └──[🔀] $ref (58000:13)❌ 
│ └─┬/_plugins/_security/api/nodesdn/{cluster_name}
│   ├─┬GET
│   │ └─┬Responses
│   │   └─┬200
│   │     └─┬application/json
│   │       └─┬Schema
│   │         └──[🔀] $ref (57817:13)❌ 
│   ├─┬PUT
│   │ └─┬Responses
│   │   └──[➕] codes (31644:7)
│   └─┬PATCH
│     └─┬Requestbody
│       └─┬application/json
│         └─┬Schema
│           └──[🔀] $ref (58000:13)❌ 
└─┬Components
  ├──[➕] responses (31644:7)
  └──[➕] schemas (58000:7)

Document Element Total Changes Breaking Changes
paths 6 4
components 2 0
  • BREAKING Changes: 4 out of 8
  • Modifications: 4
  • Additions: 4
  • Breaking Modifications: 4

Report

The full API changes report is available at: https://github.com/opensearch-project/opensearch-api-specification/actions/runs/12321124351/artifacts/2318853319

API Coverage

Before After Δ
Covered (%) 606 (59.35 %) 606 (59.35 %) 0 (0 %)
Uncovered (%) 415 (40.65 %) 415 (40.65 %) 0 (0 %)
Unknown 43 43 0

@dblock dblock force-pushed the nodesdn-tests branch 5 times, most recently from 8cdd4d7 to 4252b5e Compare December 13, 2024 18:18
Copy link
Contributor

Spec Test Coverage Analysis

Total Tested
536 493 (91.98 %)

@dblock dblock changed the title Added support for using a certificate and key. Added support for using a certificate and key, fixed /_plugins/_security/api/nodesdn. Dec 13, 2024
@dblock dblock marked this pull request as ready for review December 13, 2024 18:24
Signed-off-by: dblock <dblock@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant