Add publishToNuget lib and fix workspace overwrite issue for signing

[gaiksaya]

Signed-off-by: Sayali Gaikawad gaiksaya@amazon.com

Description

• Adds a new publishToNuget library that can be used to publish dotnet components Nuget Gallery
• Also fixes and resolves [Bug]: SignArtifacts.groovy clones opensearch-build in the workspace and not in a folder opensearch-build#1436

Issues Resolved

resolves opensearch-project/opensearch-build#1436
resolves opensearch-project/opensearch-build#2965

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[codecov-commenter]

Codecov Report

Merging #117 (9ec7e9d) into main (ea7a7cc) will increase coverage by 0.08%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##               main     #117      +/-   ##
============================================
+ Coverage     83.41%   83.50%   +0.08%     
  Complexity       24       24              
============================================
  Files            68       69       +1     
  Lines           193      194       +1     
  Branches         11       11              
============================================
+ Hits            161      162       +1     
  Misses           25       25              
  Partials          7        7              

Impacted Files	Coverage Δ
tests/jenkins/jobs/PublishToNuget_Jenkinsfile	100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[prudhvigodithi]

@gaiksaya LGTM, only code we have to look for is for package in find src -name OpenSearch*.nupkg``, there is no chance the package that we publish will be without OpenSearch prefix as we allow to publish only with `OpenSearch` prefix to the dotnet account, but I'm just thinking if any dependent packages exists without `OpenSearch` prefix, if so we should work with dotnet repo team.

[gaiksaya]

@gaiksaya LGTM, only code we have to look for is for package in find src -name OpenSearch*.nupkg``, there is no chance the package that we publish will be without OpenSearch prefix as we allow to publish only with `OpenSearch` prefix to the dotnet account, but I'm just thinking if any dependent packages exists without `OpenSearch` prefix, if so we should work with dotnet repo team.

Even if there are I believe we should not be signing them as our own. @Xtansia can confirm though is there is any possibility in future.

[prudhvigodithi]

Even if there are I believe we should not be signing them as our own. @Xtansia can confirm though is there is any possibility in future.

Since those dependent package dll's will be inside the .nukpg file, its better we sign them as well as they are indirectly used by the main package

[Xtansia]

Even if there are I believe we should not be signing them as our own. @Xtansia can confirm though is there is any possibility in future.

Since those dependent package dll's will be inside the .nukpg file, its better we sign them as well as they are indirectly used by the main package

The NuGet package only contains the DLL for the specific library, it doesn't contain dependencies DLLs, it's purely managed via metadata.
For example, the OpenSearch.Client library depends on the OpenSearch.Net library (which has it's own dependencies), but the OpenSearch.Client.x.y.z.nupkg only contains the OpenSearch.Client.dll (for each framework), and the OpenSearch.Net.x.y.z.nupkg only contains the OpenSearch.Net.dll (for each framework).

This can be seen here: https://nuget.info/packages/OpenSearch.Client/1.2.0

[Xtansia]

And yes, all publicly consumable packages from opensearch-net do and will have the OpenSearch. namespace.

[gaiksaya]

And yes, all publicly consumable packages from opensearch-net do and will have the OpenSearch. namespace.

Thanks! That answers our question.