Support switching ruby gems version and fix regex #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
rishabh6788
approved these changes
Feb 1, 2023
peterzhuamazon
approved these changes
Feb 1, 2023
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #119 +/- ##
=========================================
Coverage 83.41% 83.41%
Complexity 24 24
=========================================
Files 68 68
Lines 193 193
Branches 11 11
=========================================
Hits 161 161
Misses 25 25
Partials 7 7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
gaiksaya
changed the title
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com>
peterzhuamazon
approved these changes
Feb 2, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 2, 2023
Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com> (cherry picked from commit c66bc1c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
gaiksaya
pushed a commit
that referenced
this pull request
Feb 2, 2023
(cherry picked from commit c66bc1c) Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
5 tasks
gaiksaya
pushed a commit
that referenced
this pull request
Feb 6, 2023
(cherry picked from commit c66bc1c) Signed-off-by: Sayali Gaikawad <gaiksaya@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sayali Gaikawad gaiksaya@amazon.com
Description
The recent run for rubyGems failed for logstash-output-opensearch because instead of ruby it is build on jruby. https://build.ci.opensearch.org/job/logstash-output-opensearch-release/3/console
In order to fix that, this change adds the enhancement to install any ruby or jruby version as a parameter and installs it on the go.
It is required only for gem signature validation and not for building.
This change also fixes the regex which is used to retrieve the gem name.
Issues Resolved
related: opensearch-project/opensearch-build#3139
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.