[Campaign] opensearch.opensearchplugin add groupID field to org.opensearch.plugin

[prudhvigodithi]

Is your feature request related to a problem? Please describe

Main Related issue: opensearch-project/OpenSearch#4156
Track the plugins to make sure the groupId is added as org.opensearch.plugin to the publication pluginZip inside the build.gradle file.

• opensearch-plugin-template-java
• alerting
• anomaly-detection
• asynchronous-search
• common-utils
• dashboards-reports
• index-management
• job-scheduler
• k-NN
• performance-analyzer
• performance-analyzer-rca
• security
• sql
• observability
• cross-cluster-replication
• ml-commons
• geospatial
• notifications

Documentation Update: https://github.com/opensearch-project/opensearch-plugins/blob/main/BUILDING.md#opensearchpluginzip

• opensearch-plugins: Update the document BUILDING.md to reflect the new changes.

Describe the solution you'd like

Solution Implemented from the PR opensearch-project/OpenSearch#4156

Describe alternatives you've considered

N/A

Additional context

More Background about publishing plugin zips to maven: #1916
More Background on extending opensearch.pluginzip to the 3rd party plugins: opensearch-project/OpenSearch#3692

[prudhvigodithi]

Adding @lukas-vlcek @dblock @bbarani

[lukas-vlcek]

@prudhvigodithi Is there any way how I can help with 2.4 pack-porting?

I think all the individual plugin PRs have already been created and they are now waiting for review/merge. Once they are merged they will all need to be back-ported to 2.x branch before 2.4 branch is created, right? The pack-port labels are also created at this point. Is there anything I can help with?

[prudhvigodithi]

Hey @lukas-vlcek thanks for checking :), yes 2.4 branch is not yet cut, it will be done from 2.x, right now the 2.4 release is being tested using 2.x branch https://github.com/opensearch-project/opensearch-build/blob/main/manifests/2.4.0/opensearch-2.4.0.yml, so at this point we are good.

[prudhvigodithi]

Hey @lukas-vlcek Just noticed this error with notifications-core when executing ./gradlew publishToMavenLocal (coming from build script)
I have raised the PR to add startParameter.excludedTaskNames=["publishPluginZipPublicationToMavenLocal"], to fix the error org.gradle.api.publish.maven.InvalidMavenPublicationException:
adding @reta

[lukas-vlcek]

Please see my comment here: opensearch-project/notifications#554 (comment)

[prudhvigodithi]

Hey @lukas-vlcek when you get a chance can you please do Documentation Update for your changes?
https://github.com/opensearch-project/opensearch-plugins/blob/main/BUILDING.md#opensearchpluginzip
@bbarani @dblock @reta

[lukas-vlcek]

@prudhvigodithi Please see opensearch-project/opensearch-plugins#175

[prudhvigodithi]

Closing this issue as all the associated tasks are completed. @lukas-vlcek @bbarani @peterzhuamazon

[jmazanec15]

@prudhvigodithi If all plugins are updating groupID to org.opensearch.plugin, is there any reason to keep group as org.opensearch? Ref:

1. https://github.com/opensearch-project/opensearch-plugins/blob/main/BUILDING.md#building-within-the-opensearch-build-system

I was getting failures related to this when trying to publishToMavenLocal for k-NN that were fixed by switching group to "org.opensearch.plugins":

./gradlew :publishToMavenLocal -Dbuild.snapshot=true
...
> Task :publishNebulaPublicationToMavenLocal FAILED
Execution optimizations have been disabled for task ':publishNebulaPublicationToMavenLocal' to ensure correctness due to the following reasons:
  - Gradle detected a problem with the following location: '/Users/jmazane/workspace/Opensearch/DockerRunner/k-NN-1/build/distributions/opensearch-knn-3.0.0.0-SNAPSHOT.pom'. Reason: Task ':publishNebulaPublicationToMavenLocal' uses this output of task ':generatePomFileForPluginZipPublication' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed. Please refer to https://docs.gradle.org/7.5/userguide/validation_problems.html#implicit_dependency for more details about this problem.

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':publishNebulaPublicationToMavenLocal'.
> Failed to publish publication 'nebula' to repository 'mavenLocal'
   > Invalid publication 'nebula': supplied groupId (org.opensearch) does not match value from POM file (org.opensearch.plugin). Cannot edit groupId directly in the POM file.

Related: opensearch-project/k-NN#596

[jmazanec15]

Ah looks like its related to opensearch-project/notifications#554 (comment).