Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support release process for spring-data-opensearch #2846

Closed
reta opened this issue Nov 3, 2022 · 14 comments
Closed

Support release process for spring-data-opensearch #2846

reta opened this issue Nov 3, 2022 · 14 comments
Assignees
Labels
enhancement New Enhancement

Comments

@reta
Copy link
Contributor

reta commented Nov 3, 2022

Is your feature request related to a problem? Please describe

We have a new repository https://github.com/opensearch-project/spring-data-opensearch to support OpenSearch integration with Spring projects ecosystem (based on Spring Data Elasticsearch).

Describe the solution you'd like

The release process is not yet in place, the artifacts are: signed JARs under org.opensearch.client group (Sonatype or alternative public Apache Maven repositories).

Describe alternatives you've considered

N/A

Additional context

The release / snapshots Jenkins jobs are ready: opensearch-project/spring-data-opensearch#46

@reta reta added enhancement New Enhancement untriaged Issues that have not yet been triaged labels Nov 3, 2022
@reta
Copy link
Contributor Author

reta commented Nov 3, 2022

CC @peterzhuamazon

@prudhvigodithi
Copy link
Member

prudhvigodithi commented Nov 8, 2022

[Triage] This can added as part of universal release mechanism with maven.

@dlvenable
Copy link
Member

@prudhvigodithi , What is the timeframe for the universal release mechanism? The spring-data-opensearch project is ready for -SNAPSHOT releases now and probably almost ready for the 0.1 release as well. I'd like to make the snapshots available to users so they can start giving feedback.

@dlvenable
Copy link
Member

@prudhvigodithi , This spring-data-opensearch project's most similar project is opensearch-java. Whatever mechanism is in place for opensearch-java today may be usable for spring-data-opensearch.

@prudhvigodithi
Copy link
Member

Thanks @dlvenable adding @gaiksaya and @peterzhuamazon can we continue to use the same mechanism used at opensearch-java?
@bbarani

@gaiksaya
Copy link
Member

Hey! I'll update this issue on 11/21 after discussing few pointers with the team.
Thanks!

@reta
Copy link
Contributor Author

reta commented Nov 21, 2022

FYI, the Jenkins files are PRed opensearch-project/spring-data-opensearch#46

@gaiksaya
Copy link
Member

gaiksaya commented Dec 14, 2022

Adding some details here.

We have Publish to Maven lib ready #2398 however some minor bugs were discovered during testing which @rishabh6788 is working on this fix.
The snapshot publishing feature will be added as a part of the same library.

As stated in universal release diagram we will be not building any artifacts on the system since the CI system and release systems are different and can lead to discrepancies in the artifacts shipped to the customer. Please see #1234 for details.

Question regarding the release @reta @dlvenable I see there are multiple components in that repository like

@reta
Copy link
Contributor Author

reta commented Dec 14, 2022

  • Will all of them be released at the same time always? Or is there a possibility of releasing them independently in future?

Thanks @gaiksaya , they all will be released at the same time (or none).

@gaiksaya
Copy link
Member

Hi @reta ,

The spring data OpenSearch repo is set for the release. We have added the webhook and the job to be monitored is here https://build.ci.opensearch.org/job/spring-data-opensearch-release/

When are you planning to push a tag?

@reta
Copy link
Contributor Author

reta commented Dec 15, 2022

When are you planning to push a tag?

Thanks @gaiksaya , once opensearch-project/spring-data-opensearch#75 is in, I will cut the tag

@gaiksaya
Copy link
Member

gaiksaya commented Jan 4, 2023

Spring data opensearch 0.1.0 is released now: https://repo1.maven.org/maven2/org/opensearch/client/

@gaiksaya gaiksaya closed this as completed Jan 4, 2023
@gaiksaya
Copy link
Member

Hi @reta,

You can now publish snaphots to maven using GHA directly. See the PR[1] as an example on what all needs to be added to make that happen. You can add me as a reviewer once PR is ready so that I can make changes at the backend and add the required role to retrieve the credentials.
Thanks!

[1] opensearch-project/opensearch-java#325

@reta
Copy link
Contributor Author

reta commented Jan 18, 2023

This is awesome, thanks a lot @gaiksaya ! I will take it shortly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New Enhancement
Projects
None yet
Development

No branches or pull requests

5 participants