Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rvm dynamic installation and jruby #3169

Merged

Conversation

peterzhuamazon
Copy link
Member

Signed-off-by: Peter Zhu zhujiaxi@amazon.com

Description

Add rvm dynamic installation and jruby

Issues Resolved

#3139

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2023

Codecov Report

Merging #3169 (891105a) into main (1eb20f6) will decrease coverage by 0.31%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #3169      +/-   ##
==========================================
- Coverage   93.19%   92.89%   -0.31%     
==========================================
  Files         167      167              
  Lines        4614     4614              
==========================================
- Hits         4300     4286      -14     
- Misses        314      328      +14     
Impacted Files Coverage Δ
src/system/temporary_directory.py 64.44% <0.00%> (-28.89%) ⬇️
src/system/os.py 94.73% <0.00%> (-5.27%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@peterzhuamazon
Copy link
Member Author

This allow rvm to be used without root.

@gaiksaya
Copy link
Member

gaiksaya commented Feb 2, 2023

This allow rvm to be used without root.

We still need to specify the source right? source /usr/share/opensearch/.rvm/scripts/rvm

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
@peterzhuamazon
Copy link
Member Author

This allow rvm to be used without root.

We still need to specify the source right? source /usr/share/opensearch/.rvm/scripts/rvm

Yes

@gaiksaya gaiksaya merged commit 47e3c2b into opensearch-project:main Feb 2, 2023
@peterzhuamazon peterzhuamazon deleted the jruby-release-images branch February 2, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants