-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for inclusive naming #156
Add support for inclusive naming #156
Conversation
Signed-off-by: Thomas Farr <tsfarr@amazon.com>
Signed-off-by: Thomas Farr <tsfarr@amazon.com>
Signed-off-by: Thomas Farr <tsfarr@amazon.com>
Signed-off-by: Thomas Farr <tsfarr@amazon.com>
ee0a2d2
to
35524fc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good to me. Bar the one question I had.
@@ -46,7 +46,7 @@ func TestBuild_zipfileUrl(t *testing.T) { | |||
"build_id": "1.0.0-ab7cd914", | |||
"projects": { | |||
"opensearch": { | |||
"branch": "master", | |||
"branch": "main", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Xtansia Do we know if the branch change has happened? I was unable to find the artifact listed here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@harshavamsi This is just test data, not actually used other than to validate some logic that pulls out the archive url.
@dblock @VachaShah @wbeckler This looks good to me, bar the one flaky integration test and whitesource CVE that I'm not sure are relevant here. |
Please open an issue for the flaky test failure in https://github.com/opensearch-project/opensearch-go/actions/runs/3012819413/jobs/4841298373? |
@dblock Looks like Vacha already encountered and created an issue for it: #163 |
Description
cluster_manager_timeout
parameter, deprecatingmaster_timeout
/_cat/cluster_manager
endpoint, deprecating/_cat/master
cluster_manager
node role in the discovery logicWithLocal
methods to use cluster-manager terminology.Issues Resolved
Resolves #121
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.