Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for inclusive naming #156

Merged
merged 4 commits into from
Oct 11, 2022

Conversation

Xtansia
Copy link
Contributor

@Xtansia Xtansia commented Sep 8, 2022

Description

  • Adds the cluster_manager_timeout parameter, deprecating master_timeout
  • Adds the /_cat/cluster_manager endpoint, deprecating /_cat/master
  • Correctly handle the cluster_manager node role in the discovery logic
  • Updates the documentation of the WithLocal methods to use cluster-manager terminology.

Issues Resolved

Resolves #121

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Xtansia Xtansia requested review from a team and svencowart as code owners September 8, 2022 06:03
Signed-off-by: Thomas Farr <tsfarr@amazon.com>
Signed-off-by: Thomas Farr <tsfarr@amazon.com>
Signed-off-by: Thomas Farr <tsfarr@amazon.com>
Signed-off-by: Thomas Farr <tsfarr@amazon.com>
@Xtansia Xtansia force-pushed the feat/inclusive-naming branch from ee0a2d2 to 35524fc Compare September 8, 2022 06:06
Copy link
Contributor

@harshavamsi harshavamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me. Bar the one question I had.

@@ -46,7 +46,7 @@ func TestBuild_zipfileUrl(t *testing.T) {
"build_id": "1.0.0-ab7cd914",
"projects": {
"opensearch": {
"branch": "master",
"branch": "main",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Xtansia Do we know if the branch change has happened? I was unable to find the artifact listed here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harshavamsi This is just test data, not actually used other than to validate some logic that pulls out the archive url.

@harshavamsi
Copy link
Contributor

@dblock @VachaShah @wbeckler This looks good to me, bar the one flaky integration test and whitesource CVE that I'm not sure are relevant here.

@dblock
Copy link
Member

dblock commented Oct 5, 2022

@dblock dblock requested a review from VachaShah October 5, 2022 18:14
@Xtansia
Copy link
Contributor Author

Xtansia commented Oct 7, 2022

Please open an issue for the flaky test failure in https://github.com/opensearch-project/opensearch-go/actions/runs/3012819413/jobs/4841298373?

@dblock Looks like Vacha already encountered and created an issue for it: #163

@dblock dblock merged commit cd6193e into opensearch-project:main Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add support for inclusive naming
4 participants