Replaced if_seq_num to if_seq_no #166
Conversation
|
Please amend the commit with Is this something we can/should have a unit test for? |
noname4life
force-pushed
the
fix-seq-num
branch
from
4c2a329 to
89c1e2a
Compare
|
Thank you for the review and noted on this. I have amended the commit and have added a unit test for this change. |
|
Something's off with CI/CD 🤔 Looks like DCO is still failing though, maybe squash your commits locally and force push? LMK if you need help? |
noname4life
force-pushed
the
fix-seq-num
branch
from
f1d5553 to
d86a113
Compare
|
It seems to have been caused by certain configurations in my local. Updated the commit to address this. |
|
The linter is failing now, take a look? |
|
Hi @dblock , the failing linter seems to be caused by the go version 1.16.2 in the lint.yml file in reference to the returned error of the lint github action which indicated a required go version of 1.17. I have pushed a commit to bump the go version. |
|
Hi @noname4life, can you please rebase to get the latest changes from main? Thank you! |
noname4life
force-pushed
the
fix-seq-num
branch
from
55c5ce5 to
d7b2b28
Compare
|
Hi @VachaShah, I have rebased this branch with the updates from main. Kindly let me know if I have missed anything. Thank you! |
Signed-off-by: Kyle Darryl Aguilar <aguilarkyledarryl@gmail.com>
Signed-off-by: Kyle Darryl Aguilar <aguilarkyledarryl@gmail.com>
noname4life
force-pushed
the
fix-seq-num
branch
from
d7b2b28 to
cff4dcb
Compare
|
Hi @dblock @VachaShah , I have added an entry in CHANGELOG |
Thank you @noname4life, re-running the workflows |
Signed-off by: Kyle Darryl Aguilar aguilarkyledarryl@gmail.com
Description
Renamed the sequence number struct tag to resolve issues when performing optimistic concurrency control
Issues Resolved
Resolves #165
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.