Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump link check action version #478

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

Jakob3xD
Copy link
Collaborator

Description

Bump link checker action version

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Jakob Hahn <jakob.hahn@hetzner.com>
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 12.84%. Comparing base (e68de80) to head (9453e69).

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #478       +/-   ##
===========================================
- Coverage   57.26%   12.84%   -44.42%     
===========================================
  Files         315      315               
  Lines        9823     9823               
===========================================
- Hits         5625     1262     -4363     
- Misses       2904     8484     +5580     
+ Partials     1294       77     -1217     
Flag Coverage Δ
integration ?
unit 12.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 301 files with indirect coverage changes

@dblock
Copy link
Member

dblock commented Feb 27, 2024

Let's fix the CI/CD for those other failures before merging more?

@Jakob3xD
Copy link
Collaborator Author

Let's fix the CI/CD for those other failures before merging more?

This is one of the fixes as link checked fails in the dependency update PRs. Or do you want one larger PR to fix all CI issues?

@dblock dblock merged commit 34c199e into opensearch-project:main Feb 27, 2024
48 of 55 checks passed
@dblock
Copy link
Member

dblock commented Feb 27, 2024

Let's fix the CI/CD for those other failures before merging more?

This is one of the fixes as link checked fails in the dependency update PRs. Or do you want one larger PR to fix all CI issues?

Yeah I saw this elsewhere, thanks. Merged this one.

@Jakob3xD Jakob3xD deleted the jh-link-check branch February 28, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants