Add the Explanation field containing the document explain details to SearchHit #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zr-bennettm
requested review from
dblock,
VijayanB,
VachaShah and
Jakob3xD
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #504 +/- ##
==========================================
+ Coverage 57.26% 57.29% +0.03%
==========================================
Files 315 315
Lines 9823 9823
==========================================
+ Hits 5625 5628 +3
+ Misses 2904 2902 -2
+ Partials 1294 1293 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Thank you for the PR. Looks good so far. You can run the tests locally by following the steps in the developer guide. |
|
@Jakob3xD just added one |
dblock
approved these changes
Apr 3, 2024
dblock
requested changes
Apr 3, 2024
There was a problem hiding this comment.
@zr-bennettm You will need to sign DCO (git commit -s --amend and force push) for all your commits, please.
|
Looks like #506 is fixing CI, rebase after that's merged. |
Jakob3xD
requested changes
Apr 3, 2024
…SearchHit Signed-off-by: Bennett Mountain <bennettm@ziprecruiter.com>
Signed-off-by: zr-bennettm <165848212+zr-bennettm@users.noreply.github.com>
Signed-off-by: Bennett Mountain <bennettm@ziprecruiter.com>
…inter Signed-off-by: Bennett Mountain <bennettm@ziprecruiter.com>
Jakob3xD
approved these changes
Apr 3, 2024
dblock
approved these changes
Apr 3, 2024
|
We release often. Open an issue like "Release v.Next", if you need a release quickly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, calling the
Searchfunction here withExplainset to true inParamsin theSearchReqdid not add an explanation payload to each document. This pull request fixes that by adding anExplanationfield to theSearchHitstruct.Issues Resolved
This resolves issue 503, which I raised.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.