Add missing _routing field in SearchHit interface #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tushar <tmonga06@gmail.com>
tushar2404
requested review from
dblock,
VijayanB,
VachaShah and
Jakob3xD
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #516 +/- ##
===========================================
+ Coverage 57.29% 67.96% +10.66%
===========================================
Files 315 376 +61
Lines 9823 8852 -971
===========================================
+ Hits 5628 6016 +388
+ Misses 2902 1555 -1347
+ Partials 1293 1281 -12
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Tushar <tmonga06@gmail.com>
|
Thanks for the PR. |
Signed-off-by: Tushar <tmonga06@gmail.com>
tushar2404
force-pushed
the
add-routing-key-in-search-hit-interface
branch
2 times, most recently
from
84aeb45 to
ab6e69f
Compare
Signed-off-by: tushar2404 <53367076+tushar2404@users.noreply.github.com>
done |
Jakob3xD
requested changes
Apr 22, 2024
Signed-off-by: Tushar <tmonga06@gmail.com>
Jakob3xD
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added Routing field in SearchHit interface
premise:
The OpenSearch Search API currently does not return the routing key in its responses. The routing key is a crucial piece of information, especially in cases where the user or the application has specified a custom routing key for a document at the time of its creation. This omission means that any application or user querying documents from OpenSearch will not receive this key as part of the search results.
Issues Resolved
This pull request addresses this gap by adding a Routing field to the SearchHit interface. With this change, the API will now include the routing key in the search results.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.