-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds missing field due to new opensearch version #552
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #552 +/- ##
===========================================
+ Coverage 57.29% 67.96% +10.67%
===========================================
Files 315 376 +61
Lines 9823 8853 -970
===========================================
+ Hits 5628 6017 +389
+ Misses 2902 1555 -1347
+ Partials 1293 1281 -12
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the CHANGELOG should just say "Added support for OpenSearch 2.14", although mentioning fields is fine too.
There's a tab/space change here (https://github.com/opensearch-project/opensearch-go/pull/552/files?w=1 shows a clean diff), is this not desired or are we correcting poor auto-format from before?
Feel free to amend or just merge.
Signed-off-by: Jakob Hahn <jakob.hahn@hetzner.com>
Correcting poor format as the new line between the messages is unneded. |
I didn't mean CHANGELOG, in all the .go files there's a diff spacing. |
The Spacing is done automatically by go fmt as the new struct field name is so long. |
Description
Fix current integration tests due to missing fields.
Issues Resolved
List any issues this PR will resolve, e.g. Closes [...].
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.