Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds missing field due to new opensearch version #552

Merged
merged 1 commit into from
May 22, 2024

Conversation

Jakob3xD
Copy link
Collaborator

Description

Fix current integration tests due to missing fields.

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.96%. Comparing base (06a6dc8) to head (4447aee).
Report is 25 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #552       +/-   ##
===========================================
+ Coverage   57.29%   67.96%   +10.67%     
===========================================
  Files         315      376       +61     
  Lines        9823     8853      -970     
===========================================
+ Hits         5628     6017      +389     
+ Misses       2902     1555     -1347     
+ Partials     1293     1281       -12     
Flag Coverage Δ
integration 60.39% <ø> (+9.55%) ⬆️
unit 15.28% <ø> (+2.43%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
opensearchapi/api_cat-shards.go 100.00% <ø> (ø)
opensearchapi/api_indices-stats.go 85.71% <ø> (+2.38%) ⬆️
opensearchapi/api_nodes-stats.go 100.00% <ø> (ø)
plugins/security/api_securityconfig-get.go 100.00% <ø> (ø)

... and 269 files with indirect coverage changes

@Jakob3xD Jakob3xD changed the title Adds search_idle_reactivate_count_total field to structs Adds missing field due to new opensearch version May 21, 2024
@Jakob3xD Jakob3xD marked this pull request as ready for review May 21, 2024 11:51
dblock
dblock previously approved these changes May 21, 2024
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the CHANGELOG should just say "Added support for OpenSearch 2.14", although mentioning fields is fine too.

There's a tab/space change here (https://github.com/opensearch-project/opensearch-go/pull/552/files?w=1 shows a clean diff), is this not desired or are we correcting poor auto-format from before?

Feel free to amend or just merge.

CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: Jakob Hahn <jakob.hahn@hetzner.com>
@Jakob3xD
Copy link
Collaborator Author

There's a tab/space change here (https://github.com/opensearch-project/opensearch-go/pull/552/files?w=1 shows a clean diff), is this not desired or are we correcting poor auto-format from before?

Correcting poor format as the new line between the messages is unneded.

@dblock
Copy link
Member

dblock commented May 22, 2024

There's a tab/space change here (https://github.com/opensearch-project/opensearch-go/pull/552/files?w=1 shows a clean diff), is this not desired or are we correcting poor auto-format from before?

Correcting poor format as the new line between the messages is unneded.

I didn't mean CHANGELOG, in all the .go files there's a diff spacing.

@Jakob3xD
Copy link
Collaborator Author

I didn't mean CHANGELOG, in all the .go files there's a diff spacing.

The Spacing is done automatically by go fmt as the new struct field name is so long.

@dblock dblock merged commit 285f5c2 into opensearch-project:main May 22, 2024
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants