Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] add a module-info.java to support JPMS properly #108

Closed
SingingBush opened this issue Feb 9, 2022 · 2 comments
Closed

[FEATURE] add a module-info.java to support JPMS properly #108

SingingBush opened this issue Feb 9, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@SingingBush
Copy link

I'm currently trying to build a modular jar of my app that depends on:

<dependency>
    <groupId>org.opensearch.client</groupId>
    <artifactId>opensearch-rest-high-level-client</artifactId>
    <version>1.2.4</version>
    <scope>compile</scope>
</dependency>

but as the opensearch java clients don't have module-info.java files it's defaulting to try and do the modularity based on the classes in the file. This would potentially be okay if it wasn't for the fact that the org.opensearch.client package is available in two places.

module myapp reads package org.opensearch.client from both opensearch.rest.high.level.client and opensearch.rest.client

This is probably something that can be solved by properly supporting the module system.

@SingingBush SingingBush added the enhancement New feature or request label Feb 9, 2022
@reta
Copy link
Collaborator

reta commented Feb 9, 2022

@SingingBush you may check opensearch-project/OpenSearch#1838, opensearch-rest-high-level-client depends on quite a few core modules which have to be modularized first

@SingingBush
Copy link
Author

thanks for linking the existing ticket. The split packages problem will certainly need to be solved. I also noticed that the high level client pulls in a lot of transient dependencies that probably aren't needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants