Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set javadoc encoding to UTF-8 #50

Closed
VijayanB opened this issue Oct 15, 2021 · 5 comments · Fixed by #241
Closed

set javadoc encoding to UTF-8 #50

VijayanB opened this issue Oct 15, 2021 · 5 comments · Fixed by #241
Assignees
@meetesh
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@VijayanB
Copy link
Member

Refer comment here: #49
@VijayanB VijayanB mentioned this issue Oct 15, 2021
Merged
1 task
@VijayanB VijayanB added good first issue Good for newcomers help wanted Extra attention is needed labels Oct 19, 2021
@wbeckler
Copy link

wbeckler commented Aug 7, 2022

If anyone wants to do this, it's still a nice first issue to resolve.

@meetesh
Copy link
Contributor

meetesh commented Oct 13, 2022 •
edited
Loading

Hi @wbeckler @VijayanB , I am willing to work on this, can you please assign. Thanks!

meetesh added a commit to miqdigital/opensearch-java that referenced this issue Oct 13, 2022
@meetesh
Set javadoc encoding to utf-8 (opensearch-project#50)
d939cd6 
Signed-off-by: Meetesh Kumawat<kmeetesh@gmail.com>
This was referenced Oct 13, 2022
Closed
Merged
@wbeckler
Copy link

Awesome! I will do

@dblock
Copy link
Member

dblock commented Oct 13, 2022 •
edited
Loading

#237 and #49

@dblock dblock closed this as completed Oct 13, 2022
meetesh added a commit to miqdigital/opensearch-java that referenced this issue Oct 14, 2022
@meetesh
Merge pull request #1 from miqdigital/issue-50
7b92dcf 
Set javadoc encoding to utf-8 (opensearch-project#50)
Signed-off-by: Meetesh Kumawat <kmeetesh@gmail.com>
@meetesh meetesh mentioned this issue Oct 14, 2022
Merged
meetesh added a commit to miqdigital/opensearch-java that referenced this issue Oct 14, 2022
@meetesh
Set javadoc encoding to utf-8 (opensearch-project#50)
6181fcb 
Signed-off-by: Meetesh Kumawat<kmeetesh@gmail.com>
Signed-off-by: meetesh <kmeetesh@gmail.com>
@meetesh
Copy link
Contributor

meetesh commented Oct 14, 2022

Hi @dblock, I notice that you've closed this issue but the PR i've raised is not merged yet. I had to close my earlier PR due to an issue. Have raised a new PR: #241, Please check.

@dblock dblock reopened this Oct 14, 2022
VachaShah pushed a commit that referenced this issue Oct 14, 2022
@meetesh
Set javadoc encoding to utf-8 (#50) (#241)
3b58e0c 
Signed-off-by: Meetesh Kumawat<kmeetesh@gmail.com>
Signed-off-by: meetesh <kmeetesh@gmail.com>

Signed-off-by: Meetesh Kumawat<kmeetesh@gmail.com>
Signed-off-by: meetesh <kmeetesh@gmail.com>
abhinav-nath pushed a commit to abhinav-nath/opensearch-java that referenced this issue Oct 21, 2022
@meetesh @abhinav-nath
Set javadoc encoding to utf-8 (opensearch-project#50) (opensearch-pro…
960a67b 
…ject#241)

Signed-off-by: Meetesh Kumawat<kmeetesh@gmail.com>
Signed-off-by: meetesh <kmeetesh@gmail.com>

Signed-off-by: Meetesh Kumawat<kmeetesh@gmail.com>
Signed-off-by: meetesh <kmeetesh@gmail.com>
abhinav-nath pushed a commit to abhinav-nath/opensearch-java that referenced this issue Oct 21, 2022
@meetesh @abhinav-nath
Set javadoc encoding to utf-8 (opensearch-project#50) (opensearch-pro…
ee7ed8f 
…ject#241)

Signed-off-by: Meetesh Kumawat<kmeetesh@gmail.com>
Signed-off-by: meetesh <kmeetesh@gmail.com>

Signed-off-by: Meetesh Kumawat<kmeetesh@gmail.com>
Signed-off-by: meetesh <kmeetesh@gmail.com>
Signed-off-by: Abhinav Nath <abhinavnath@ymail.com>
VachaShah pushed a commit that referenced this issue Oct 21, 2022
@abhinav-nath @harshavamsi
@meetesh @reta @dblock @dependabot
Add support to parse sub-aggregations from filter/nested aggregations (…
1ac790a 
…#234)

* Add support to parse sub-aggregations from filter/nested aggregations

Signed-off-by: Abhinav Nath <abhinavnath@ymail.com>

* Add USER_GUIDE.md

Signed-off-by: Abhinav Nath <abhinavnath@ymail.com>

* Add DCO

Signed-off-by: Abhinav Nath <abhinavnath@ymail.com>

* Add link to USER_GUIDE.md in README.md

Signed-off-by: Abhinav Nath <abhinavnath@ymail.com>

* Add changelog and changelog verifier (#239)

Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>

Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
Signed-off-by: Abhinav Nath <abhinavnath@ymail.com>

* Set javadoc encoding to utf-8 (#50) (#241)

Signed-off-by: Meetesh Kumawat<kmeetesh@gmail.com>
Signed-off-by: meetesh <kmeetesh@gmail.com>

Signed-off-by: Meetesh Kumawat<kmeetesh@gmail.com>
Signed-off-by: meetesh <kmeetesh@gmail.com>
Signed-off-by: Abhinav Nath <abhinavnath@ymail.com>

* Update Jackson Databind to 2.13.4.2 (addressing CVE-2022-42003) (#240)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: Abhinav Nath <abhinavnath@ymail.com>

* Updates changelog for dependabot PRs (#247)

* Updates changelog for dependabot PRs

Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>

* Adding dependabot label for workflow

Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>

Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
Signed-off-by: Abhinav Nath <abhinavnath@ymail.com>

* Update tests to use JUnit's Assert (#244)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: Abhinav Nath <abhinavnath@ymail.com>

* Update literature around changelog (#242)

* Update literature

Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>

* Removing pr template and updating language

Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>

Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
Co-authored-by: Daniel (dB.) Doubrovkine <dblock@amazon.com>
Signed-off-by: Abhinav Nath <abhinavnath@ymail.com>

* Bump grgit-gradle from 4.0.1 to 5.0.0 (#243)

* Bump grgit-gradle from 4.0.1 to 5.0.0

Bumps [grgit-gradle](https://github.com/ajoberstar/grgit) from 4.0.1 to 5.0.0.
- [Release notes](https://github.com/ajoberstar/grgit/releases)
- [Commits](ajoberstar/grgit@4.0.1...5.0.0)

---
updated-dependencies:
- dependency-name: org.ajoberstar.grgit:grgit-gradle
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* Update changelog

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Signed-off-by: Abhinav Nath <abhinavnath@ymail.com>

* Add DCO

Signed-off-by: Abhinav Nath <abhinavnath@ymail.com>

* Update CHANGELOG and README

Signed-off-by: Abhinav Nath <abhinavnath@ymail.com>

* Add DCO

Signed-off-by: Abhinav Nath <abhinavnath@ymail.com>

* Add DCO

Signed-off-by: Abhinav Nath <abhinavnath@ymail.com>

* Fix CHANGLOG and README TOC

Signed-off-by: Abhinav Nath <abhinavnath@ymail.com>

Signed-off-by: Abhinav Nath <abhinavnath@ymail.com>
Signed-off-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
Signed-off-by: Meetesh Kumawat<kmeetesh@gmail.com>
Signed-off-by: meetesh <kmeetesh@gmail.com>
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Harsha Vamsi Kalluri <harshavamsi096@gmail.com>
Co-authored-by: Meetesh Kumawat <kmeetesh@gmail.com>
Co-authored-by: Andriy Redko <andriy.redko@aiven.io>
Co-authored-by: Daniel (dB.) Doubrovkine <dblock@amazon.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@meetesh meetesh

Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set javadoc encoding to utf-8 miqdigital/opensearch-java
4 participants
@dblock @wbeckler @meetesh @VijayanB