Removing strong dependency for jakarta-json-api #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vacha Shah <vachshah@amazon.com>
owaiskazi19
reviewed
Sep 14, 2022
| // EPL-2.0 OR GPL-2.0 WITH Classpath-exception-2.0 | ||
| // https://github.com/eclipse-ee4j/jsonp | ||
| api("jakarta.json:jakarta.json-api:2.0.1") | ||
|
|
There was a problem hiding this comment.
Can we remove strong dependencies of
api("com.google.code.findbugs:jsr305:3.0.2")
api("org.eclipse.parsson:parsson:1.1.1")
implementation("jakarta.json.bind", "jakarta.json.bind-api", "2.0.0")
as a part of this PR?
There was a problem hiding this comment.
All of them look like they are being used.
dblock
approved these changes
Sep 20, 2022
saratvemulapalli
approved these changes
Oct 5, 2022
|
probably wont need this #226 any more :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vacha Shah vachshah@amazon.com
Description
Removing strong dependency for jakarta-json-api-2.0.1
Issues Resolved
Resolves #201
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.